Skip to content

Immediate force-close itest#2177

Open
GeorgeTsagk wants to merge 2 commits into
lightninglabs:mainfrom
GeorgeTsagk:immediate-close-itest-stack
Open

Immediate force-close itest#2177
GeorgeTsagk wants to merge 2 commits into
lightninglabs:mainfrom
GeorgeTsagk:immediate-close-itest-stack

Conversation

@GeorgeTsagk

@GeorgeTsagk GeorgeTsagk commented Jun 25, 2026

Copy link
Copy Markdown
Member

Description

Adds an itest edge-case where a tap channel is force closed immediately without any commitment updates.

Needs an LND update too, so blocked on lightningnetwork/lnd#10804
Based on #2133
Now also based on #2186 as we need the v2 deps bump

@gemini-code-assist

Copy link
Copy Markdown

Warning

Gemini encountered an error creating the summary. You can try again by commenting /gemini summary.

@GeorgeTsagk
GeorgeTsagk force-pushed the immediate-close-itest-stack branch 2 times, most recently from 4558394 to b8bb5a4 Compare June 29, 2026 13:34
@kaldun-tech

Copy link
Copy Markdown
Contributor

/gemini summary

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

This pull request introduces a new integration test to validate the edge case of force-closing a tap channel immediately after funding. To support this, the PR includes critical updates to the auxiliary funding and sweeping logic, ensuring that commitment output allocations and BTC balances are correctly calculated to maintain consistency with on-chain commitment transactions.

Highlights

  • New Integration Test: Added a new integration test case to verify that a tap channel can be force-closed immediately after funding without any prior asset movement.
  • Auxiliary Funding Logic: Updated the initial BTC balance calculation in the funding controller to ensure commitment output ordering matches the real commitment transaction.
  • Sweeper Refactoring: Refactored commitment output allocation logic to correctly handle exclusion proofs for real commitment transactions on-chain.
  • Dependency Updates: Updated several project dependencies in go.mod and go.sum to ensure compatibility and stability.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Activity
  • Pull request created by GeorgeTsagk.
  • Gemini encountered an error generating the initial summary.
  • User requested a new summary via the /gemini summary command.

@GeorgeTsagk
GeorgeTsagk force-pushed the immediate-close-itest-stack branch 3 times, most recently from 662ba4e to d19e3b2 Compare July 1, 2026 18:36

@jtobin jtobin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Pretty sure this one LGTM, just holding off on further review/approval until the upstream lnd PR lands.)

@jtobin jtobin added this to the v0.9 milestone Jul 8, 2026
@GeorgeTsagk
GeorgeTsagk force-pushed the immediate-close-itest-stack branch from d19e3b2 to 17b5586 Compare July 16, 2026 12:20
@lightninglabs-deploy

Copy link
Copy Markdown

@GeorgeTsagk, remember to re-request review from reviewers when ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

4 participants