Skip to content

Add an --external_ip configruation option to the daemon #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
Roasbeef opened this issue Feb 12, 2017 · 1 comment
Closed
2 tasks

Add an --external_ip configruation option to the daemon #135

Roasbeef opened this issue Feb 12, 2017 · 1 comment
Labels
beginner Issues suitable for new developers discovery Peer and route discovery / whisper protocol related issues/PRs p2p Code related to the peer-to-peer behaviour
Milestone

Comments

@Roasbeef
Copy link
Member

Currently, the TCP address that all daemons advertise is incorrect ([::]:10019). This is lifted from the set of listening addresses that are set within the configuration on boot up. As a result, none of the NodeAnnouncement messages propagated within the network don't contain any true reachability information. This should be remedied to allow a user to optionally specify a set of public reaches IP(s).

Steps to Completion

  • Add a new attribute to the struct in config.go: ExternalIP.

  • The value(s) from this attribute (if set) should be used within the NodeAnnouncement propagated through the network, rather than the first value from out side of listening addresses.

@Roasbeef Roasbeef added beginner Issues suitable for new developers discovery Peer and route discovery / whisper protocol related issues/PRs p2p Code related to the peer-to-peer behaviour labels Feb 12, 2017
@Roasbeef Roasbeef added this to the v0.2-alpha milestone Feb 12, 2017
@Roasbeef
Copy link
Member Author

Closed by #154.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner Issues suitable for new developers discovery Peer and route discovery / whisper protocol related issues/PRs p2p Code related to the peer-to-peer behaviour
Projects
None yet
Development

No branches or pull requests

1 participant