You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Roasbeef opened this issue
Feb 12, 2017
· 1 comment
Labels
beginnerIssues suitable for new developersdiscoveryPeer and route discovery / whisper protocol related issues/PRsp2pCode related to the peer-to-peer behaviour
Currently, the TCP address that all daemons advertise is incorrect ([::]:10019). This is lifted from the set of listening addresses that are set within the configuration on boot up. As a result, none of the NodeAnnouncement messages propagated within the network don't contain any true reachability information. This should be remedied to allow a user to optionally specify a set of public reaches IP(s).
Steps to Completion
Add a new attribute to the struct in config.go: ExternalIP.
The value(s) from this attribute (if set) should be used within the NodeAnnouncement propagated through the network, rather than the first value from out side of listening addresses.
The text was updated successfully, but these errors were encountered:
Roasbeef
added
beginner
Issues suitable for new developers
discovery
Peer and route discovery / whisper protocol related issues/PRs
p2p
Code related to the peer-to-peer behaviour
labels
Feb 12, 2017
beginnerIssues suitable for new developersdiscoveryPeer and route discovery / whisper protocol related issues/PRsp2pCode related to the peer-to-peer behaviour
Currently, the TCP address that all daemons advertise is incorrect (
[::]:10019
). This is lifted from the set of listening addresses that are set within the configuration on boot up. As a result, none of theNodeAnnouncement
messages propagated within the network don't contain any true reachability information. This should be remedied to allow a user to optionally specify a set of public reaches IP(s).Steps to Completion
Add a new attribute to the struct in
config.go
:ExternalIP
.The value(s) from this attribute (if set) should be used within the
NodeAnnouncement
propagated through the network, rather than the first value from out side of listening addresses.The text was updated successfully, but these errors were encountered: