Skip to content

Ensure the connmgr doesn't attempt to establish connections based off of incoming connection info #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Roasbeef opened this issue Feb 12, 2017 · 1 comment
Labels
beginner Issues suitable for new developers bug Unintended code behaviour
Milestone

Comments

@Roasbeef
Copy link
Member

Currently, if we receive an incoming connection, then the port we store in the database for the IP address that made that incoming connection is the port the TCP connection was assigned to after the initial handshake completed. Upon boot (if we later establish a channel with that node), the daemon will then tell the connmgr to establish a persistent connection to that peer, however the connection will fail indefinitely as it's attempting to use the non-default TCP port.

The logic around establishing persistent connections should be modified to instead store the advertise IP+port information within the peer's NodeAnnouncement rather than the information we obtain upon connection.

@Roasbeef Roasbeef added beginner Issues suitable for new developers bug Unintended code behaviour labels Feb 12, 2017
@Roasbeef Roasbeef added this to the v0.2-alpha milestone Feb 12, 2017
@Roasbeef
Copy link
Member Author

Closed by #154.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner Issues suitable for new developers bug Unintended code behaviour
Projects
None yet
Development

No branches or pull requests

1 participant