Skip to content

Commit 19ebfb6

Browse files
Fix undefined cname race condition
Co-authored-by: Jan Dubois <[email protected]>
1 parent dbc04dc commit 19ebfb6

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

pkg/hostagent/dns.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,10 @@ func (h *Handler) handleQuery(w dns.ResponseWriter, req *dns.Msg) {
7676
switch q.Qtype {
7777
case dns.TypeCNAME, dns.TypeA, dns.TypeAAAA:
7878
cname, err := net.LookupCNAME(q.Name)
79-
if err == nil && cname != "" && cname != q.Name {
79+
if err != nil {
80+
break
81+
}
82+
if cname != "" && cname != q.Name {
8083
hdr.Rrtype = dns.TypeCNAME
8184
a := &dns.CNAME{
8285
Hdr: hdr,

0 commit comments

Comments
 (0)