Store Lima version in the instance directory

That way future Lima releases can make decisions about default settings
based on the Lima version that created the instance instead of the current
instance, and settings for existing instances will not change just because
the user updated Lima.

Signed-off-by: Jan Dubois <[email protected]>

Author: jandubois

cmd/limactl/start.go

@@ -23,6 +23,7 @@ import (
 	"github.com/lima-vm/lima/pkg/store/filenames"
 	"github.com/lima-vm/lima/pkg/templatestore"
 	"github.com/lima-vm/lima/pkg/uiutil"
+	"github.com/lima-vm/lima/pkg/version"
 	"github.com/lima-vm/lima/pkg/yqutil"
 	"github.com/sirupsen/logrus"
 	"github.com/spf13/cobra"
@@ -332,6 +333,9 @@ func createInstance(ctx context.Context, st *creatorState, saveBrokenEditorBuffe
 	if err := os.WriteFile(filePath, st.yBytes, 0o644); err != nil {
 		return nil, err
 	}
+	if err := os.WriteFile(filepath.Join(instDir, filenames.LimaVersion), []byte(version.Version), 0o644); err != nil {
+		return nil, err
+	}
 
 	inst, err := store.Inspect(st.instName)
 	if err != nil {

pkg/store/filenames/filenames.go

@@ -27,6 +27,7 @@ const (
 
 const (
 	LimaYAML           = "lima.yaml"
+	LimaVersion        = "lima-version" // Lima version used to create instance
 	CIDataISO          = "cidata.iso"
 	CIDataISODir       = "cidata"
 	BaseDisk           = "basedisk"

pkg/store/instance.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"github.com/sirupsen/logrus"
 	"io"
 	"os"
 	"os/user"
@@ -16,6 +17,7 @@ import (
 	"text/template"
 	"time"
 
+	"github.com/coreos/go-semver/semver"
 	"github.com/docker/go-units"
 	hostagentclient "github.com/lima-vm/lima/pkg/hostagent/api/client"
 	"github.com/lima-vm/lima/pkg/limayaml"
@@ -35,6 +37,8 @@ const (
 	StatusRunning       Status = "Running"
 )
 
+const DefaultLimaVersion = "v0.19.1"
+
 type Instance struct {
 	Name            string             `json:"name"`
 	Status          Status             `json:"status"`
@@ -56,6 +60,7 @@ type Instance struct {
 	Config          *limayaml.LimaYAML `json:"config,omitempty"`
 	SSHAddress      string             `json:"sshAddress,omitempty"`
 	Protected       bool               `json:"protected"`
+	LimaVersion     string             `json:"limaVersion"`
 }
 
 func (inst *Instance) LoadYAML() (*limayaml.LimaYAML, error) {
@@ -167,6 +172,14 @@ func Inspect(instName string) (*Instance, error) {
 			}
 		}
 	}
+	if version, err := os.ReadFile(filepath.Join(instDir, filenames.LimaVersion)); err == nil {
+		inst.LimaVersion = strings.TrimSpace(string(version))
+	} else {
+		if !errors.Is(err, os.ErrNotExist) {
+			inst.Errors = append(inst.Errors, err)
+		}
+		inst.LimaVersion = DefaultLimaVersion
+	}
 	return inst, nil
 }
 
@@ -423,3 +436,22 @@ func (inst *Instance) Unprotect() error {
 	inst.Protected = false
 	return nil
 }
+
+// MinVersion checks if the instance has been created by the specified minimum version of Lima.
+// Prerelease versions are treated as the previous version, not the next, so "0.19.1-16-gf3dc6ed.m"
+// is considered the same as "0.19.1" and not "0.20.0".
+func MinVersion(instanceVersion, minVersion string) bool {
+	v := strings.TrimPrefix(instanceVersion, "v")
+	v, _, _ = strings.Cut(v, "-")
+	instVers, err := semver.NewVersion(v)
+	if err != nil {
+		logrus.Warnf("cannot parse instance version %q", instanceVersion)
+		return false
+	}
+	minVers, err := semver.NewVersion(minVersion)
+	if err != nil {
+		logrus.Warnf("cannot parse minimum version %q", minVersion)
+		return false
+	}
+	return !instVers.LessThan(*minVers)
+}