Skip to content

The MinGW and MSYS2 terminals are not supported on Windows #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
afbjorklund opened this issue Jul 1, 2022 · 3 comments
Closed

The MinGW and MSYS2 terminals are not supported on Windows #936

afbjorklund opened this issue Jul 1, 2022 · 3 comments

Comments

@afbjorklund
Copy link
Member

afbjorklund commented Jul 1, 2022

Description

The TTY works on Posix and it works on Windows command prompt (DOS),
but it does not work when using a Unix terminal such as mintty on Windows.

  • MinGW (like in Git for Windows)

  • MSYS2

The detection uses IsCygwinTerminal rather than the usual IsTerminal,
and the survey module is hardcoded to use either/or (based on the GOOS)


This breaks the template selection ("Incorrect function")

But it also breaks terminal handling when running shell

Other side effects was JSON logging to the terminal too

And different output when it comes to the downloader

@afbjorklund
Copy link
Member Author

afbjorklund commented Jul 2, 2022

The code in logrus also failed to detect these terminals, overrriding with ForceColors

vendor/github.com/sirupsen/logrus/text_formatter.go:	isColored := f.ForceColors || (f.isTerminal && (runtime.GOOS != "windows"))

@afbjorklund
Copy link
Member Author

The workaround for the template selection, is either to use template:// or winpty.exe:

winpty limactl start

@Cactusinhand
Copy link

The workaround for the template selection, is either to use template:// or winpty.exe:

@afbjorklund
Sorry, what does template:// mean here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants