Enable Binary artifacts check for local repos (#2)

abhiseksanyal · Abhisek Sanyal · abhiseksanyal · commit 35ceedd93492 · 2023-07-06T21:07:24.000Z
Enable Binary artifacts check for local repositories that was disabled in the PR ossf#2039 and revert the change done for empty repository handling in the PR ossf#2207 Co-authored-by: Abhisek Sanyal <abhisek@veedna.com>
diff --git a/checks/binary_artifact.go b/checks/binary_artifact.go
@@ -27,6 +27,7 @@ const CheckBinaryArtifacts string = "Binary-Artifacts"
 //nolint
 func init() {
 	supportedRequestTypes := []checker.RequestType{
+		checker.FileBased,
 		checker.CommitBased,
 	}
 	if err := registerCheck(CheckBinaryArtifacts, BinaryArtifacts, supportedRequestTypes); err != nil {
diff --git a/pkg/scorecard.go b/pkg/scorecard.go
@@ -105,7 +105,7 @@ func RunScorecard(ctx context.Context,
 	defer repoClient.Close()
 
 	commitSHA, err := getRepoCommitHash(repoClient)
-	if err != nil || commitSHA == "" {
+	if err != nil {
 		return ScorecardResult{}, err
 	}
 	defaultBranch, err := repoClient.GetDefaultBranchName()

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ const CheckBinaryArtifacts string = "Binary-Artifacts"`
`27`	`27`	`//nolint`
`28`	`28`	`func init() {`
`29`	`29`	`supportedRequestTypes := []checker.RequestType{`
	`30`	`+ checker.FileBased,`
`30`	`31`	`checker.CommitBased,`
`31`	`32`	`}`
`32`	`33`	`if err := registerCheck(CheckBinaryArtifacts, BinaryArtifacts, supportedRequestTypes); err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ func RunScorecard(ctx context.Context,`
`105`	`105`	`defer repoClient.Close()`
`106`	`106`
`107`	`107`	`commitSHA, err := getRepoCommitHash(repoClient)`
`108`		`- if err != nil \|\| commitSHA == "" {`
	`108`	`+ if err != nil {`
`109`	`109`	`return ScorecardResult{}, err`
`110`	`110`	`}`
`111`	`111`	`defaultBranch, err := repoClient.GetDefaultBranchName()`