Skip to content

fix: exclude pseudo locale during sync #1455

Merged
andrii-bodnar merged 2 commits into
lingui:nextfrom
taozhou-glean:fix-service
Feb 22, 2023
Merged

fix: exclude pseudo locale during sync #1455
andrii-bodnar merged 2 commits into
lingui:nextfrom
taozhou-glean:fix-service

Conversation

@taozhou-glean
Copy link
Copy Markdown
Contributor

@taozhou-glean taozhou-glean commented Feb 21, 2023

Description

Looks like we only exclude pseudo while init but not sync, might be just an oversight, as I was touching it, so I also added the types for the config object.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes #1454

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works: no tests exists for services yet
  • I have added necessary documentation (if appropriate)

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 7:56PM (UTC)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 21, 2023

size-limit report 📦

Path Size
./packages/core/build/esm/index.js 1.76 KB (0%)
./packages/detect-locale/build/esm/index.js 812 B (0%)
./packages/react/build/esm/index.js 1.79 KB (0%)
./packages/remote-loader/build/esm/index.js 7.29 KB (0%)

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 21, 2023

Codecov Report

Base: 72.27% // Head: 72.15% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (d650b17) compared to base (6b6adc9).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1455      +/-   ##
==========================================
- Coverage   72.27%   72.15%   -0.12%     
==========================================
  Files          74       74              
  Lines        1897     1900       +3     
  Branches      510      511       +1     
==========================================
  Hits         1371     1371              
- Misses        422      425       +3     
  Partials      104      104              
Impacted Files Coverage Δ
packages/cli/src/services/translationIO.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread packages/cli/src/services/translationIO.ts Outdated
@andrii-bodnar
Copy link
Copy Markdown
Contributor

@taozhou-glean thank you!

@andrii-bodnar andrii-bodnar merged commit cb3548d into lingui:next Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid 'target_languages': pseudo. while sync with Translation.io

4 participants