feat(macro): support renamed identifiers in macro#1463
Merged
andrii-bodnar merged 1 commit intoFeb 24, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
30b3200 to
d57f6f1
Compare
size-limit report 📦
|
d57f6f1 to
abf8f26
Compare
Codecov ReportBase: 73.96% // Head: 74.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next #1463 +/- ##
==========================================
+ Coverage 73.96% 74.15% +0.18%
==========================================
Files 75 75
Lines 1928 1942 +14
Branches 514 517 +3
==========================================
+ Hits 1426 1440 +14
Misses 383 383
Partials 119 119
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
|
What about the SWC plugin? Does it also need this or it already supports this? |
Collaborator
Author
|
It already supports. |
andrii-bodnar
approved these changes
Feb 23, 2023
Martin005
approved these changes
Feb 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support for all macros.:
Looks like this is a rare case, because no one has raised the issue so far. But that is quite common case if code after other transpiler would be passed to lingui (custom extractor case)
Types of changes
Fixes # (issue)
Checklist