fix: allow passing any expression as custom i18n instance

[janicduplessis]

Description

Currently passing a custom i18n instance to the t macro only supports passing identifier, although any expression should be valid.

For example this currently crashes during extraction:

t(context.intl)`Hello`;

This changes the check from isIdentifier to isExpression so we can support function calls or member properties.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Checklist

• I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
js-lingui	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 1, 2023 at 7:10PM (UTC)

[github-actions]

size-limit report 📦

Path	Size
./packages/core/build/esm/index.js	1.76 KB (0%)
./packages/detect-locale/build/esm/index.js	812 B (0%)
./packages/react/build/esm/index.js	1.79 KB (0%)
./packages/remote-loader/build/esm/index.js	7.29 KB (0%)

[timofei-iatsenko]

@janicduplessis thanks for you contribution. We have an active development in next branch. Please port your changes there.

[janicduplessis]

@thekip Ok, I rebased against the next branch

[andrii-bodnar]

@thekip do we need the same fix for the SWC plugin?

[timofei-iatsenko]

I'm not sure. We need to write the same test case and check how it behaves.

Extra point: we need somehow to write a universal test fixtures for both SWC and Babel transform, to be always sure that they behave the same