fix(extractor): allow i18._(foo.bar) without warning.#1492
Merged
Conversation
size-limit report 📦
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## next #1492 +/- ##
==========================================
- Coverage 73.92% 73.90% -0.02%
==========================================
Files 67 67
Lines 1875 1870 -5
Branches 489 489
==========================================
- Hits 1386 1382 -4
Misses 383 383
+ Partials 106 105 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
andrii-bodnar
approved these changes
Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Actually, this bug is a bit wider:
#1432
The extractor don't rise warning only if
Identifieris used as first argument. But user may passfoo.bar(MemeberExpression) or even function call.This PR fixes this cases by actually disabling this check entirely. Because any syntax could be used for translation.
The check of empty ID is still works with other usaceases, such as Macro, ObjectExpression, etc
I also refactored extracting an id from
i18n._()and now it supports template literals as well as string concatenation.Types of changes
Fixes # (issue)
Checklist