fix: just use require to import services#1647
Merged
Merged
Conversation
- update services to be async and can be awaited
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1647 +/- ##
==========================================
- Coverage 75.33% 75.26% -0.08%
==========================================
Files 77 77
Lines 1995 1997 +2
Branches 517 517
==========================================
Hits 1503 1503
- Misses 377 379 +2
Partials 115 115
☔ View full report in Codecov by Sentry. |
timofei-iatsenko
approved these changes
May 10, 2023
Collaborator
timofei-iatsenko
left a comment
There was a problem hiding this comment.
Thanks, that should help.
3 tasks
andrii-bodnar
approved these changes
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
from #1631, there is error importing TranslationIO service with
import. It result inCannot find module. The problem is that it need the js extension.One solution is to add js extension
import('xxx' + .js), but the result would still need to beNot sure why the double default there, but using require would solve at least the double default.
Types of changes
Fixes # (issue)
#1631
Checklist