fix: revert use useSyncExternalStore to subscribe for context updates#1755
Merged
Conversation
…pdates (lingui#1746)" This reverts commit 47d4fdb.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3 tasks
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1755 +/- ##
==========================================
- Coverage 75.98% 75.95% -0.03%
==========================================
Files 81 81
Lines 2065 2063 -2
Branches 530 529 -1
==========================================
- Hits 1569 1567 -2
Misses 383 383
Partials 113 113
☔ View full report in Codecov by Sentry. |
andrii-bodnar
approved these changes
Aug 31, 2023
Contributor
andrii-bodnar
left a comment
There was a problem hiding this comment.
@vonovak thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 47d4fdb (#1746)
this closes #1754.
For now, this seems to be the best way to go about this, probably until facebook/react#26230 is released.
Description
Types of changes
Fixes # (issue)
Checklist