fix: warnings about invalid dependencies on Windows#1828
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1828 +/- ##
=======================================
Coverage 76.39% 76.39%
=======================================
Files 81 81
Lines 2072 2072
Branches 529 529
=======================================
Hits 1583 1583
Misses 377 377
Partials 112 112 ☔ View full report in Codecov by Sentry. |
Contributor
|
@bravo-kernel thank you! How about adding tests as it was mentioned in the discord thread? |
Contributor
Author
|
@andrii-bodnar, those comments about (restructuring tests) read as optional/nice-to-have to me.
Do you feel they are mandatory changes? |
Contributor
|
@bravo-kernel ok, nice to have |
andrii-bodnar
approved these changes
Jan 4, 2024
Contributor
Author
|
Thank you for merging, I will give restructuring of the tests a try. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The build emits warnings on Windows as described in detail at https://discord.com/channels/974702239358783608/974704045346394172/1141002196398391436.
This PR contains the fix described here https://discord.com/channels/974702239358783608/1136285611087626250/1141022716237987980.
Types of changes
Fixes #1705.
After this fix, Windows no longer emits the warnings.
Tests are not affected.
Checklist