Skip to content

fix: run type tests in test:all#2017

Merged
andrii-bodnar merged 1 commit into
lingui:mainfrom
anbernar:fix-test-all-script
Aug 29, 2024
Merged

fix: run type tests in test:all#2017
andrii-bodnar merged 1 commit into
lingui:mainfrom
anbernar:fix-test-all-script

Conversation

@anbernar
Copy link
Copy Markdown
Contributor

Description

Type tests do not run when calling the test:all or release:test scripts.

Instead, there is the following error message:

command not found: test:tsd

This PR makes the type tests to run by fixing the test:all script, and subsequently the release:test script, which depends on the test:all script.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 10:31pm

@github-actions
Copy link
Copy Markdown

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.88 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.34%. Comparing base (d6b9698) to head (138ada3).
Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2017      +/-   ##
==========================================
- Coverage   76.65%   75.34%   -1.31%     
==========================================
  Files          81       85       +4     
  Lines        2090     2146      +56     
  Branches      533      547      +14     
==========================================
+ Hits         1602     1617      +15     
- Misses        375      415      +40     
- Partials      113      114       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar merged commit b9e89c1 into lingui:main Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants