feat(format-po-gettext): respect Plural-Forms header#2070
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
timofei-iatsenko
approved these changes
Nov 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2070 +/- ##
==========================================
- Coverage 76.65% 75.84% -0.81%
==========================================
Files 81 89 +8
Lines 2090 2227 +137
Branches 533 560 +27
==========================================
+ Hits 1602 1689 +87
- Misses 375 425 +50
Partials 113 113 ☔ View full report in Codecov by Sentry. |
andrii-bodnar
approved these changes
Nov 6, 2024
Contributor
andrii-bodnar
left a comment
There was a problem hiding this comment.
@garikkh thank you!
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Certain TMS might provide a different
Plural-Formsheader with gettext-style PO files. Instead of depending on using either CLDR or gettext defined plurals, change the gettext formatter to consider the header.See related PR: #2010
Types of changes
Checklist