feat(react): preserve newlines during string formatting#2158
Merged
andrii-bodnar merged 1 commit intoJan 27, 2025
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
timofei-iatsenko
approved these changes
Jan 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2158 +/- ##
==========================================
- Coverage 77.05% 76.38% -0.67%
==========================================
Files 84 87 +3
Lines 2157 2439 +282
Branches 555 637 +82
==========================================
+ Hits 1662 1863 +201
- Misses 382 460 +78
- Partials 113 116 +3 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In @lingui/react, newlines in translations are not preserved during formatting (rendering), when
<tags>are present.Please see this demo: https://codesandbox.io/p/devbox/infallible-cdn-y863cd
This PR ensures that formatting is done the same way for both variants: with and without
<tags>.Types of changes
Fixes #2157
Checklist