Skip to content

fix(extractor): sort placeholders to keep them stable between runs#2307

Merged
andrii-bodnar merged 1 commit into
mainfrom
fix/placeholder-stable-sorting
Aug 5, 2025
Merged

fix(extractor): sort placeholders to keep them stable between runs#2307
andrii-bodnar merged 1 commit into
mainfrom
fix/placeholder-stable-sorting

Conversation

@timofei-iatsenko
Copy link
Copy Markdown
Collaborator

Description

Added sorting and test for placeholders

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes #2306

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Aug 5, 2025 8:46am

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 5, 2025

size-limit report 📦

Path Size
packages/core/dist/index.mjs 1.88 KB (0%)
packages/detect-locale/dist/index.mjs 618 B (0%)
packages/react/dist/index.mjs 1.35 KB (0%)

@andrii-bodnar andrii-bodnar merged commit decf4cd into main Aug 5, 2025
9 checks passed
@andrii-bodnar andrii-bodnar deleted the fix/placeholder-stable-sorting branch August 5, 2025 11:15
@jtbandes
Copy link
Copy Markdown
Contributor

jtbandes commented Aug 8, 2025

Hi there -- any chance of a patch release for this fix? We are starting to see CI failures due to this bug. Thanks! 🙏

@andrii-bodnar
Copy link
Copy Markdown
Contributor

Hi @jtbandes, available in v5.4.1

@nopitown
Copy link
Copy Markdown

Actually, after this update, my file started to get unstable, and between each run, I get a different order 😕

@jtbandes
Copy link
Copy Markdown
Contributor

I have still seen this issue once or twice, but it seems more rare after 5.4.1...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extracted comments ordering is not stable

4 participants