Skip to content

fix: plural pseudolocalization with offset#887

Merged
tricoder42 merged 1 commit into
lingui:mainfrom
MartinCerny-awin:fix-pseudolocalization-plural
Nov 26, 2020
Merged

fix: plural pseudolocalization with offset#887
tricoder42 merged 1 commit into
lingui:mainfrom
MartinCerny-awin:fix-pseudolocalization-plural

Conversation

@MartinCerny-awin
Copy link
Copy Markdown
Contributor

@MartinCerny-awin MartinCerny-awin commented Nov 24, 2020

I have improved RegEx for plurals. It now correctly escapes plural with offset. This is fix for #743, but it does not close it as there is need to escape other React components like Select, SelectOrdinal & DateFormat

I was not able to test the code because of this #886

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/i9jwxr4x8
✅ Preview: https://js-lingui-git-fix-pseudolocalization-plural.lingui-js.now.sh

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 24, 2020

Codecov Report

Merging #887 (744cd70) into main (5cade19) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #887   +/-   ##
=======================================
  Coverage   82.91%   82.91%           
=======================================
  Files          51       51           
  Lines        1440     1440           
  Branches      395      395           
=======================================
  Hits         1194     1194           
  Misses        145      145           
  Partials      101      101           
Impacted Files Coverage Δ
packages/cli/src/api/pseudoLocalize.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cade19...744cd70. Read the comment docs.

@semoal
Copy link
Copy Markdown
Contributor

semoal commented Nov 25, 2020

Give it a try to the new contributing.md and let us know if all works properly 👍🏻

@MartinCerny-awin
Copy link
Copy Markdown
Contributor Author

@semoal it works well, I happy for the pr to be merged

@tricoder42
Copy link
Copy Markdown
Contributor

Perfect, thanks for testing it! 👍

@tricoder42 tricoder42 merged commit 3d54b4d into lingui:main Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants