fix: plural pseudolocalization with offset#887
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lingui-js/js-lingui/i9jwxr4x8 |
Codecov Report
@@ Coverage Diff @@
## main #887 +/- ##
=======================================
Coverage 82.91% 82.91%
=======================================
Files 51 51
Lines 1440 1440
Branches 395 395
=======================================
Hits 1194 1194
Misses 145 145
Partials 101 101
Continue to review full report at Codecov.
|
|
Give it a try to the new contributing.md and let us know if all works properly 👍🏻 |
|
@semoal it works well, I happy for the pr to be merged |
|
Perfect, thanks for testing it! 👍 |
I have improved RegEx for plurals. It now correctly escapes plural with offset. This is fix for #743, but it does not close it as there is need to escape other React components like Select, SelectOrdinal & DateFormat
I was not able to test the code because of this #886