Skip to content

feat: ship universal modules with ESM#979

Merged
semoal merged 2 commits into
mainfrom
esm-integration
Feb 23, 2021
Merged

feat: ship universal modules with ESM#979
semoal merged 2 commits into
mainfrom
esm-integration

Conversation

@semoal
Copy link
Copy Markdown
Contributor

@semoal semoal commented Feb 21, 2021

Pending testing on vite, snowpack and similar projects to test that everything work as expected

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/BDwWQr9DunJteXF8Y816rPDYqXiF
✅ Preview: https://js-lingui-git-esm-integration-lingui-js.vercel.app

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 21, 2021

Size Change: 0 B

Total Size: 7.42 kB

ℹ️ View Unchanged
Filename Size Change
./packages/core/build/cjs/core.production.min.js 2.09 kB 0 B
./packages/core/build/cjs/dev.production.min.js 2.09 kB 0 B
./packages/detect-locale/build/cjs/detect-locale.production.min.js 961 B 0 B
./packages/react/build/cjs/react.production.min.js 2.28 kB 0 B

compressed-size-action

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 21, 2021

Codecov Report

Merging #979 (f7ae033) into main (0844dfc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #979   +/-   ##
=======================================
  Coverage   83.30%   83.30%           
=======================================
  Files          53       53           
  Lines        1605     1605           
  Branches      430      430           
=======================================
  Hits         1337     1337           
  Misses        156      156           
  Partials      112      112           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0844dfc...f7ae033. Read the comment docs.

chore: reverted yarn.lock
@semoal semoal marked this pull request as ready for review February 23, 2021 12:39
@semoal semoal changed the title chore: build universal modules to ESM feat: ship universal modules with ESM Feb 23, 2021
@semoal semoal merged commit 6cd5fe0 into main Feb 23, 2021
@semoal semoal deleted the esm-integration branch February 23, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant