Skip to content

fix: use pkgUp.sync to localize package.json#985

Merged
semoal merged 1 commit into
lingui:mainfrom
capaj:use-pkg-up
Mar 1, 2021
Merged

fix: use pkgUp.sync to localize package.json#985
semoal merged 1 commit into
lingui:mainfrom
capaj:use-pkg-up

Conversation

@capaj
Copy link
Copy Markdown
Contributor

@capaj capaj commented Feb 25, 2021

This will help detect the correct project type in situations where you want to have multiple lingui configs in a project with a shared package.json.
For example having backend and frontend in separate folders.

I haven't tested this.

This will help in situations where you want to have multiple lingui configs in one project. For example having backend and frontend in one folder with a single package.json while having mutliple lingui configs.
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/6jbJptvEuRMQd1BBnKpwT5FHuWnB
✅ Preview: https://js-lingui-git-fork-capaj-use-pkg-up-lingui-js.vercel.app

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 25, 2021

Codecov Report

Merging #985 (a0665f1) into main (77ec0bd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #985   +/-   ##
=======================================
  Coverage   83.30%   83.30%           
=======================================
  Files          53       53           
  Lines        1605     1605           
  Branches      430      430           
=======================================
  Hits         1337     1337           
  Misses        156      156           
  Partials      112      112           
Impacted Files Coverage Δ
packages/cli/src/api/detect.ts 64.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77ec0bd...a0665f1. Read the comment docs.

@semoal semoal changed the title use pkgUp.sync to localize the package.json fix: use pkgUp.sync to localize package.json Mar 1, 2021
@semoal semoal merged commit 18d985d into lingui:main Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants