fix: Report correct number of missing messages in strict mode#992
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lingui-js/js-lingui/FvVh3jF63jCy8qWYsi16fb9Z7ERH |
Codecov Report
@@ Coverage Diff @@
## main #992 +/- ##
=======================================
Coverage 83.30% 83.30%
=======================================
Files 53 53
Lines 1605 1605
Branches 430 430
=======================================
Hits 1337 1337
Misses 156 156
Partials 112 112 Continue to review full report at Codecov.
|
Contributor
|
Lgtm, thanks mate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There are two problems about the report of missing translations of
lingui compile --strict:--verboseoption, missing values, which are alwaysundefined, are reported. It is less useful.Changes
This PR fixes the above problems. Under the following situation:
Before
Reports the total number of translations as the number of missing ones:
Reports
undefinedas the missing translations:After
Reports the correct number of missing translations:
Reports missing translation message Ids: