From cfe79ecc75b50a75d77be14587e8009d23a3c5c8 Mon Sep 17 00:00:00 2001 From: tubo213 Date: Wed, 4 Feb 2026 01:34:35 +0900 Subject: [PATCH] Fix CLIPVisionModel hidden_states issue in Llava convergence test Remove importlib.reload(modeling_clip) from revert_liger_kernel_to_llava() as it breaks CLIPVisionModel's output_hidden_states functionality in transformers v5. Liger kernel does not patch modeling_clip when model=None, so reloading it is unnecessary and causes hidden_states to return None. --- test/utils.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/utils.py b/test/utils.py index 94fd3e9fd..dea1c95f2 100644 --- a/test/utils.py +++ b/test/utils.py @@ -620,11 +620,12 @@ def revert_liger_kernel_to_llava(model_config: MiniModelConfig): Revert all Liger kernel patches applied to llava. """ - from transformers.models.clip import modeling_clip from transformers.models.llama import modeling_llama from transformers.models.llava import modeling_llava - importlib.reload(modeling_clip) + # Note: Do NOT reload modeling_clip as it breaks CLIPVisionModel's + # output_hidden_states functionality in transformers v5. + # Liger kernel does not patch modeling_clip when model=None. importlib.reload(modeling_llava) importlib.reload(modeling_llama)