Merge pull request #2894 from asauber/test-gen-actions

Add tests for the core Redux action creator generator

Author: asauber

src/api/internal.js

@@ -46,23 +46,24 @@ function parseIntIfActualInt(string) {
   return isNaN(string) ? string : parseInt(string);
 }
 
-const actionGenerators = {
-  [ONE]: c => (resource, ...ids) => (dispatch) =>
+const actionCreatorGenerators = {
+  // These functions take a config and return Redux Action Creators
+  [ONE]: config => (resource, ...ids) => (dispatch) =>
     dispatch({
       resource,
       dispatch,
-      type: `GEN@${fullyQualified(c)}/ONE`,
+      type: `GEN@${fullyQualified(config)}/ONE`,
       ids: ids.map(parseIntIfActualInt),
     }),
-  [MANY]: c => (page, ...ids) => (dispatch) =>
+  [MANY]: config => (page, ...ids) => (dispatch) =>
     dispatch({
       page,
       dispatch,
-      type: `GEN@${fullyQualified(c)}/MANY`,
+      type: `GEN@${fullyQualified(config)}/MANY`,
       ids: ids.map(parseIntIfActualInt),
     }),
-  [DELETE]: c => (...ids) =>
-    ({ type: `GEN@${fullyQualified(c)}/DELETE`, ids: ids.map(parseIntIfActualInt) }),
+  [DELETE]: config => (...ids) =>
+    ({ type: `GEN@${fullyQualified(config)}/DELETE`, ids: ids.map(parseIntIfActualInt) }),
 };
 
 /**
@@ -76,8 +77,8 @@ export function genActions(config) {
     [DELETE]: 'delete',
   };
   config.supports.forEach((feature) => {
-    if (typeof actionGenerators[feature] !== 'undefined') {
-      actions[fns[feature]] = actionGenerators[feature](config);
+    if (typeof actionCreatorGenerators[feature] !== 'undefined') {
+      actions[fns[feature]] = actionCreatorGenerators[feature](config);
     }
   });
   if (config.subresources) {

src/api/internal.spec.js

@@ -0,0 +1,44 @@
+import { genActions } from './internal';
+
+import { testConfigOne, testConfigMany, testConfigDelete } from '~/data/reduxGen';
+import { resource, page } from '~/data/reduxGen';
+
+describe('internal', () => {
+  it('generates an action to update one resource', function () {
+    const dispatch = jest.fn();
+
+    const config = testConfigOne;
+
+    const actions = genActions(config);
+    const oneThunk = actions.one(resource, '23');
+    oneThunk(dispatch);
+
+    expect(dispatch.mock.calls[0][0].resource.label).toBe('nodebalancer-1');
+    expect(dispatch.mock.calls[0][0].type).toBe('GEN@nodebalancers/ONE');
+    expect(dispatch.mock.calls[0][0].ids[0]).toBe(23);
+  });
+
+  it('generates an action to update many resources', function () {
+    const dispatch = jest.fn();
+
+    const config = testConfigMany;
+
+    const actions = genActions(config);
+    const manyThunk = actions.many(page);
+    manyThunk(dispatch);
+    expect(dispatch.mock.calls[0][0].page.nodebalancers[0].label)
+      .toBe('nodebalancer-1');
+    expect(dispatch.mock.calls[0][0].page.nodebalancers[1].label)
+      .toBe('nodebalancer-2');
+    expect(dispatch.mock.calls[0][0].type).toBe('GEN@nodebalancers/MANY');
+  });
+
+  it('generates an action to delete a resource', function () {
+    const config = testConfigDelete;
+
+    const actions = genActions(config);
+    const deleteAction = actions.delete('23');
+    expect(deleteAction.ids[0]).toBe(23);
+    expect(deleteAction.type).toBe('GEN@nodebalancers/DELETE');
+  });
+});

src/data/reduxGen.js

@@ -0,0 +1,33 @@
+import { ONE, MANY, DELETE } from '~/api/internal';
+
+import { configsNodeBalancer, noGroupNodeBalancer } from '~/data/nodebalancers';
+
+export const resource = { ...configsNodeBalancer };
+export const page = {
+  data: [configsNodeBalancer, noGroupNodeBalancer],
+  pages: 1,
+  results: 1,
+  page: 1,
+  nodebalancers: [configsNodeBalancer, noGroupNodeBalancer],
+};
+
+export const testConfigOne = {
+  name: 'nodebalancers',
+  primaryKey: 'id',
+  endpoint: id => `/nodebalancers/${id}`,
+  supports: [ONE],
+};
+
+export const testConfigMany = {
+  name: 'nodebalancers',
+  primaryKey: 'id',
+  endpoint: id => `/nodebalancers/${id}`,
+  supports: [MANY],
+};
+
+export const testConfigDelete = {
+  name: 'nodebalancers',
+  primaryKey: 'id',
+  endpoint: id => `/nodebalancers/${id}`,
+  supports: [DELETE],
+};