Skip to content

Commit 741b2a5

Browse files
Binary-EaterNipaLocal
authored andcommitted
net/mlx5e: Fix IPsec tunnel mode offload feature check
Remove faulty check disabling checksum offload and GSO for offload of simple IPsec tunnel L4 traffic. Comment previously describing the deleted code incorrectly claimed the check prevented double tunnel (or three layers of ip headers). Fixes: f126779 ("net/mlx5: Fix checksum issue of VXLAN and IPsec crypto offload") Signed-off-by: Rahul Rameshbabu <[email protected]> Signed-off-by: Tariq Toukan <[email protected]> Reviewed-by: Simon Horman <[email protected]> Signed-off-by: NipaLocal <nipa@local>
1 parent ba302a4 commit 741b2a5

File tree

1 file changed

+5
-12
lines changed
  • drivers/net/ethernet/mellanox/mlx5/core/en_accel

1 file changed

+5
-12
lines changed

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.h

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -97,18 +97,11 @@ mlx5e_ipsec_feature_check(struct sk_buff *skb, netdev_features_t features)
9797
if (!x || !x->xso.offload_handle)
9898
goto out_disable;
9999

100-
if (xo->inner_ipproto) {
101-
/* Cannot support tunnel packet over IPsec tunnel mode
102-
* because we cannot offload three IP header csum
103-
*/
104-
if (x->props.mode == XFRM_MODE_TUNNEL)
105-
goto out_disable;
106-
107-
/* Only support UDP or TCP L4 checksum */
108-
if (xo->inner_ipproto != IPPROTO_UDP &&
109-
xo->inner_ipproto != IPPROTO_TCP)
110-
goto out_disable;
111-
}
100+
/* Only support UDP or TCP L4 checksum */
101+
if (xo->inner_ipproto &&
102+
xo->inner_ipproto != IPPROTO_UDP &&
103+
xo->inner_ipproto != IPPROTO_TCP)
104+
goto out_disable;
112105

113106
return features;
114107

0 commit comments

Comments
 (0)