[Tests] add npm run lint

Author: ljharb

.eslintrc

@@ -0,0 +1,17 @@
+{
+	"root": true,
+
+	"extends": "@ljharb",
+
+	"rules": {
+		"complexity": [2, 18],
+		"consistent-return": [1],
+		"max-params": [2, 8],
+		"max-statements": [2, 32],
+		"no-extra-parens": [1],
+		"no-continue": [1],
+		"no-magic-numbers": 0,
+		"no-restricted-syntax": [2, "BreakStatement", "DebuggerStatement", "ForInStatement", "LabeledStatement", "WithStatement"],
+		"operator-linebreak": 1
+	}
+}

lib/parse.js

@@ -31,11 +31,10 @@ internals.parseValues = function (str, options) {
             var key = Utils.decode(part.slice(0, pos));
             var val = Utils.decode(part.slice(pos + 1));
 
-            if (!Object.prototype.hasOwnProperty.call(obj, key)) {
-                obj[key] = val;
-            }
-            else {
+            if (Object.prototype.hasOwnProperty.call(obj, key)) {
                 obj[key] = [].concat(obj[key]).concat(val);
+            } else {
+                obj[key] = val;
             }
         }
     }
@@ -111,7 +110,7 @@ internals.parseKeys = function (givenKey, val, options) {
 
     var i = 0;
     while ((segment = child.exec(key)) !== null && i < options.depth) {
-        ++i;
+        i += 1;
         if (!options.plainObjects && Object.prototype.hasOwnProperty(segment[1].replace(/\[|\]/g, ''))) {
             if (!options.allowPrototypes) {
                 continue;

lib/stringify.js

@@ -5,13 +5,13 @@ var Utils = require('./utils');
 var internals = {
     delimiter: '&',
     arrayPrefixGenerators: {
-        brackets: function (prefix, key) {
+        brackets: function (prefix) {
             return prefix + '[]';
         },
         indices: function (prefix, key) {
             return prefix + '[' + key + ']';
         },
-        repeat: function (prefix, key) {
+        repeat: function (prefix) {
             return prefix;
         }
     },
@@ -25,7 +25,7 @@ internals.stringify = function (object, prefix, generateArrayPrefix, strictNullH
     if (typeof filter === 'function') {
         obj = filter(prefix, obj);
     } else if (Utils.isBuffer(obj)) {
-        obj = obj.toString();
+        obj = String(obj);
     } else if (obj instanceof Date) {
         obj = obj.toISOString();
     } else if (obj === null) {

lib/utils.js

@@ -49,10 +49,10 @@ exports.merge = function (target, source, options) {
 	return Object.keys(source).reduce(function (acc, key) {
         var value = source[key];
 
-        if (!Object.prototype.hasOwnProperty.call(acc, key)) {
-            acc[key] = value;
-        } else {
+        if (Object.prototype.hasOwnProperty.call(acc, key)) {
             acc[key] = exports.merge(acc[key], value, options);
+        } else {
+            acc[key] = value;
         }
 		return acc;
     }, mergeTarget);
@@ -107,7 +107,7 @@ exports.encode = function (str) {
             continue;
         }
 
-        ++i;
+        i += 1;
         c = 0x10000 + (((c & 0x3FF) << 10) | (string.charCodeAt(i) & 0x3FF));
         out += (hexTable[0xF0 | (c >> 18)] + hexTable[0x80 | ((c >> 12) & 0x3F)] + hexTable[0x80 | ((c >> 6) & 0x3F)] + hexTable[0x80 | (c & 0x3F)]);
     }
@@ -141,8 +141,8 @@ exports.compact = function (obj, references) {
     }
 
     var keys = Object.keys(obj);
-    for (var i = 0; i < keys.length; ++i) {
-        var key = keys[i];
+    for (var j = 0; j < keys.length; ++j) {
+        var key = keys[j];
         obj[key] = exports.compact(obj[key], refs);
     }
 

package.json

@@ -27,11 +27,15 @@
     "browserify": "^12.0.1",
     "tape": "^4.3.0",
     "covert": "^1.1.0",
-    "mkdirp": "^0.5.1"
+    "mkdirp": "^0.5.1",
+    "eslint": "^1.10.3",
+    "@ljharb/eslint-config": "^1.6.1",
+    "parallelshell": "^2.0.0"
   },
   "scripts": {
-    "test": "npm run coverage",
+    "test": "parallelshell 'npm run lint' 'npm run coverage'",
     "tests-only": "node test",
+    "lint": "eslint lib/*.js text/*.js",
     "coverage": "covert test",
     "dist": "mkdirp dist && browserify --standalone Qs lib/index.js > dist/qs.js",
     "prepublish": "npm run dist"