Skip to content

Commit c392c1e

Browse files
committed
controller-runtime v0.16.2 updates
Fix breaking changes from upgrade of controller-runtime. Breaking changes from: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0 - kubernetes-sigs/controller-runtime#2407 - kubernetes-sigs/controller-runtime#2416 HIVE-2254 Signed-off-by: Leah Leshchinsky <[email protected]>
1 parent 43cd29f commit c392c1e

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

cmd/manager/main.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"sigs.k8s.io/controller-runtime/pkg/client/config"
2222
"sigs.k8s.io/controller-runtime/pkg/manager"
2323
"sigs.k8s.io/controller-runtime/pkg/manager/signals"
24+
metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
2425

2526
_ "github.com/openshift/generic-admission-server/pkg/cmd"
2627

@@ -155,9 +156,9 @@ func newRootCommand() *cobra.Command {
155156
run := func(ctx context.Context) {
156157
// Create a new Cmd to provide shared dependencies and start components
157158
mgr, err := manager.New(cfg, manager.Options{
158-
Scheme: scheme.GetScheme(),
159-
MetricsBindAddress: ":2112",
160-
Logger: utillogrus.NewLogr(log.StandardLogger()),
159+
Scheme: scheme.GetScheme(),
160+
Metrics: metricsserver.Options{BindAddress: ":2112"},
161+
Logger: utillogrus.NewLogr(log.StandardLogger()),
161162
})
162163
if err != nil {
163164
log.Fatal(err)

cmd/operator/main.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import (
1818
"sigs.k8s.io/controller-runtime/pkg/client/config"
1919
"sigs.k8s.io/controller-runtime/pkg/manager"
2020
"sigs.k8s.io/controller-runtime/pkg/manager/signals"
21+
metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
2122

2223
_ "github.com/openshift/generic-admission-server/pkg/cmd"
2324

@@ -83,9 +84,9 @@ func newRootCommand() *cobra.Command {
8384
run := func(ctx context.Context) {
8485
// Create a new Cmd to provide shared dependencies and start components
8586
mgr, err := manager.New(cfg, manager.Options{
86-
Scheme: scheme.GetScheme(),
87-
MetricsBindAddress: ":2112",
88-
Logger: utillogrus.NewLogr(log.StandardLogger()),
87+
Scheme: scheme.GetScheme(),
88+
Metrics: metricsserver.Options{BindAddress: ":2112"},
89+
Logger: utillogrus.NewLogr(log.StandardLogger()),
8990
})
9091
if err != nil {
9192
log.Fatal(err)

test/e2e/common/machine.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ func WaitForMachines(cfg *rest.Config, testFunc func([]*machinev1.Machine) bool,
2323
scheme := scheme.GetScheme()
2424

2525
internalCache, err := cache.New(cfg, cache.Options{
26-
Namespaces: []string{"openshift-machine-api"},
27-
Scheme: scheme,
26+
DefaultNamespaces: map[string]cache.Config{"openshift-machine-api": {}},
27+
Scheme: scheme,
2828
})
2929
if err != nil {
3030
return err

0 commit comments

Comments
 (0)