[clang][Interp][NFC] Reject unimplemented cast expressions differently

tbaederr · tbaederr · commit 13b0321e978f · 2024-02-21T17:26:29.000+01:00
Instead of asserting, emit an appropriate diagnostic.
diff --git a/clang/lib/AST/Interp/ByteCodeExprGen.cpp b/clang/lib/AST/Interp/ByteCodeExprGen.cpp
@@ -335,7 +335,7 @@ bool ByteCodeExprGen<Emitter>::VisitCastExpr(const CastExpr *CE) {
     return discard(SubExpr);
 
   default:
-    assert(false && "Cast not implemented");
+    return this->emitInvalid(CE);
   }
   llvm_unreachable("Unhandled clang::CastKind enum");
 }

Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,7 @@ bool ByteCodeExprGen<Emitter>::VisitCastExpr(const CastExpr *CE) {`
`335`	`335`	`return discard(SubExpr);`
`336`	`336`
`337`	`337`	`default:`
`338`		`- assert(false && "Cast not implemented");`
	`338`	`+ return this->emitInvalid(CE);`
`339`	`339`	`}`
`340`	`340`	`llvm_unreachable("Unhandled clang::CastKind enum");`
`341`	`341`	`}`