Skip to content

Commit 41cfaf1

Browse files
committed
[clang-tools-extra] Fix add_clang_library usage
If a add_clang_library call doesn't specify building as STATIC or SHARED library they are implicitly added to the list static libraries that is linked in to clang-cpp shared library. Because the clang-tools-extra libraries targets were declared after clang-cpp they by luck never got linked to clang-cpp. This change is required for clang symbol visibility macros on windows to work correctly for clang tools since we need to distinguish if a target being built will be importing or exporting clang symbols from the clang-cpp DLL.
1 parent 3b3accb commit 41cfaf1

File tree

45 files changed

+46
-46
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+46
-46
lines changed

clang-tools-extra/clang-apply-replacements/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ set(LLVM_LINK_COMPONENTS
22
Support
33
)
44

5-
add_clang_library(clangApplyReplacements
5+
add_clang_library(clangApplyReplacements STATIC
66
lib/Tooling/ApplyReplacements.cpp
77

88
DEPENDS

clang-tools-extra/clang-change-namespace/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangChangeNamespace
6+
add_clang_library(clangChangeNamespace STATIC
77
ChangeNamespace.cpp
88

99
DEPENDS

clang-tools-extra/clang-doc/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ set(LLVM_LINK_COMPONENTS
44
FrontendOpenMP
55
)
66

7-
add_clang_library(clangDoc
7+
add_clang_library(clangDoc STATIC
88
BitcodeReader.cpp
99
BitcodeWriter.cpp
1010
ClangDoc.cpp

clang-tools-extra/clang-include-fixer/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ set(LLVM_LINK_COMPONENTS
22
support
33
)
44

5-
add_clang_library(clangIncludeFixer
5+
add_clang_library(clangIncludeFixer STATIC
66
IncludeFixer.cpp
77
IncludeFixerContext.cpp
88
InMemorySymbolIndex.cpp

clang-tools-extra/clang-include-fixer/find-all-symbols/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
FrontendOpenMP
44
)
55

6-
add_clang_library(findAllSymbols
6+
add_clang_library(findAllSymbols STATIC
77
FindAllSymbols.cpp
88
FindAllSymbolsAction.cpp
99
FindAllMacros.cpp

clang-tools-extra/clang-include-fixer/plugin/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
add_clang_library(clangIncludeFixerPlugin
1+
add_clang_library(clangIncludeFixerPlugin STATIC
22
IncludeFixerPlugin.cpp
33

44
LINK_LIBS

clang-tools-extra/clang-move/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
FrontendOpenMP
44
)
55

6-
add_clang_library(clangMove
6+
add_clang_library(clangMove STATIC
77
Move.cpp
88
HelperDeclRefGraph.cpp
99

clang-tools-extra/clang-query/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ set(LLVM_LINK_COMPONENTS
44
FrontendOpenMP
55
)
66

7-
add_clang_library(clangQuery
7+
add_clang_library(clangQuery STATIC
88
Query.cpp
99
QueryParser.cpp
1010

clang-tools-extra/clang-reorder-fields/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
support
44
)
55

6-
add_clang_library(clangReorderFields
6+
add_clang_library(clangReorderFields STATIC
77
ReorderFieldsAction.cpp
88

99
DEPENDS

clang-tools-extra/clang-tidy/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ configure_file(
88
${CMAKE_CURRENT_BINARY_DIR}/clang-tidy-config.h)
99
include_directories(BEFORE ${CMAKE_CURRENT_BINARY_DIR})
1010

11-
add_clang_library(clangTidy
11+
add_clang_library(clangTidy STATIC
1212
ClangTidy.cpp
1313
ClangTidyCheck.cpp
1414
ClangTidyModule.cpp

clang-tools-extra/clang-tidy/abseil/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
FrontendOpenMP
44
)
55

6-
add_clang_library(clangTidyAbseilModule
6+
add_clang_library(clangTidyAbseilModule STATIC
77
AbseilTidyModule.cpp
88
CleanupCtadCheck.cpp
99
DurationAdditionCheck.cpp

clang-tools-extra/clang-tidy/altera/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
support
44
)
55

6-
add_clang_library(clangTidyAlteraModule
6+
add_clang_library(clangTidyAlteraModule STATIC
77
AlteraTidyModule.cpp
88
IdDependentBackwardBranchCheck.cpp
99
KernelNameRestrictionCheck.cpp

clang-tools-extra/clang-tidy/android/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
FrontendOpenMP
44
)
55

6-
add_clang_library(clangTidyAndroidModule
6+
add_clang_library(clangTidyAndroidModule STATIC
77
AndroidTidyModule.cpp
88
CloexecAccept4Check.cpp
99
CloexecAcceptCheck.cpp

clang-tools-extra/clang-tidy/boost/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
FrontendOpenMP
44
)
55

6-
add_clang_library(clangTidyBoostModule
6+
add_clang_library(clangTidyBoostModule STATIC
77
BoostTidyModule.cpp
88
UseRangesCheck.cpp
99
UseToStringCheck.cpp

clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
FrontendOpenMP
44
)
55

6-
add_clang_library(clangTidyBugproneModule
6+
add_clang_library(clangTidyBugproneModule STATIC
77
ArgumentCommentCheck.cpp
88
AssertSideEffectCheck.cpp
99
AssignmentInIfConditionCheck.cpp

clang-tools-extra/clang-tidy/cert/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
FrontendOpenMP
44
)
55

6-
add_clang_library(clangTidyCERTModule
6+
add_clang_library(clangTidyCERTModule STATIC
77
CERTTidyModule.cpp
88
CommandProcessorCheck.cpp
99
DefaultOperatorNewAlignmentCheck.cpp

clang-tools-extra/clang-tidy/concurrency/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangTidyConcurrencyModule
6+
add_clang_library(clangTidyConcurrencyModule STATIC
77
ConcurrencyTidyModule.cpp
88
MtUnsafeCheck.cpp
99
ThreadCanceltypeAsynchronousCheck.cpp

clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangTidyCppCoreGuidelinesModule
6+
add_clang_library(clangTidyCppCoreGuidelinesModule STATIC
77
AvoidCapturingLambdaCoroutinesCheck.cpp
88
AvoidConstOrRefDataMembersCheck.cpp
99
AvoidDoWhileCheck.cpp

clang-tools-extra/clang-tidy/darwin/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangTidyDarwinModule
6+
add_clang_library(clangTidyDarwinModule STATIC
77
AvoidSpinlockCheck.cpp
88
DarwinTidyModule.cpp
99
DispatchOnceNonstaticCheck.cpp

clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangTidyFuchsiaModule
6+
add_clang_library(clangTidyFuchsiaModule STATIC
77
DefaultArgumentsCallsCheck.cpp
88
DefaultArgumentsDeclarationsCheck.cpp
99
FuchsiaTidyModule.cpp

clang-tools-extra/clang-tidy/google/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangTidyGoogleModule
6+
add_clang_library(clangTidyGoogleModule STATIC
77
AvoidCStyleCastsCheck.cpp
88
AvoidNSObjectNewCheck.cpp
99
AvoidThrowingObjCExceptionCheck.cpp

clang-tools-extra/clang-tidy/hicpp/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangTidyHICPPModule
6+
add_clang_library(clangTidyHICPPModule STATIC
77
ExceptionBaseclassCheck.cpp
88
HICPPTidyModule.cpp
99
IgnoredRemoveResultCheck.cpp

clang-tools-extra/clang-tidy/linuxkernel/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangTidyLinuxKernelModule
6+
add_clang_library(clangTidyLinuxKernelModule STATIC
77
LinuxKernelTidyModule.cpp
88
MustCheckErrsCheck.cpp
99

clang-tools-extra/clang-tidy/llvm/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangTidyLLVMModule
6+
add_clang_library(clangTidyLLVMModule STATIC
77
HeaderGuardCheck.cpp
88
IncludeOrderCheck.cpp
99
LLVMTidyModule.cpp

clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangTidyLLVMLibcModule
6+
add_clang_library(clangTidyLLVMLibcModule STATIC
77
CalleeNamespaceCheck.cpp
88
ImplementationInNamespaceCheck.cpp
99
InlineFunctionDeclCheck.cpp

clang-tools-extra/clang-tidy/misc/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ add_custom_command(
1717
add_custom_target(genconfusable DEPENDS Confusables.inc)
1818
set_target_properties(genconfusable PROPERTIES FOLDER "Clang Tools Extra/Sourcegenning")
1919

20-
add_clang_library(clangTidyMiscModule
20+
add_clang_library(clangTidyMiscModule STATIC
2121
ConstCorrectnessCheck.cpp
2222
CoroutineHostileRAIICheck.cpp
2323
DefinitionsInHeadersCheck.cpp

clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangTidyModernizeModule
6+
add_clang_library(clangTidyModernizeModule STATIC
77
AvoidBindCheck.cpp
88
AvoidCArraysCheck.cpp
99
ConcatNestedNamespacesCheck.cpp

clang-tools-extra/clang-tidy/mpi/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangTidyMPIModule
6+
add_clang_library(clangTidyMPIModule STATIC
77
BufferDerefCheck.cpp
88
MPITidyModule.cpp
99
TypeMismatchCheck.cpp

clang-tools-extra/clang-tidy/objc/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangTidyObjCModule
6+
add_clang_library(clangTidyObjCModule STATIC
77
AssertEquals.cpp
88
AvoidNSErrorInitCheck.cpp
99
DeallocInCategoryCheck.cpp

clang-tools-extra/clang-tidy/openmp/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangTidyOpenMPModule
6+
add_clang_library(clangTidyOpenMPModule STATIC
77
ExceptionEscapeCheck.cpp
88
OpenMPTidyModule.cpp
99
UseDefaultNoneCheck.cpp

clang-tools-extra/clang-tidy/performance/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangTidyPerformanceModule
6+
add_clang_library(clangTidyPerformanceModule STATIC
77
AvoidEndlCheck.cpp
88
EnumSizeCheck.cpp
99
FasterStringFindCheck.cpp

clang-tools-extra/clang-tidy/plugin/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
add_clang_library(clangTidyPlugin
1+
add_clang_library(clangTidyPlugin STATIC
22
ClangTidyPlugin.cpp
33

44
LINK_LIBS

clang-tools-extra/clang-tidy/portability/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ set(LLVM_LINK_COMPONENTS
44
TargetParser
55
)
66

7-
add_clang_library(clangTidyPortabilityModule
7+
add_clang_library(clangTidyPortabilityModule STATIC
88
PortabilityTidyModule.cpp
99
RestrictSystemIncludesCheck.cpp
1010
SIMDIntrinsicsCheck.cpp

clang-tools-extra/clang-tidy/readability/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangTidyReadabilityModule
6+
add_clang_library(clangTidyReadabilityModule STATIC
77
AvoidConstParamsInDecls.cpp
88
AvoidNestedConditionalOperatorCheck.cpp
99
AvoidReturnWithVoidValueCheck.cpp

clang-tools-extra/clang-tidy/tool/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ set(LLVM_LINK_COMPONENTS
99
# Needed by LLVM's CMake checks because this file defines multiple targets.
1010
set(LLVM_OPTIONAL_SOURCES ClangTidyMain.cpp ClangTidyToolMain.cpp)
1111

12-
add_clang_library(clangTidyMain
12+
add_clang_library(clangTidyMain STATIC
1313
ClangTidyMain.cpp
1414

1515
LINK_LIBS

clang-tools-extra/clang-tidy/utils/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangTidyUtils
6+
add_clang_library(clangTidyUtils STATIC
77
Aliasing.cpp
88
ASTUtils.cpp
99
BracesAroundStatement.cpp

clang-tools-extra/clang-tidy/zircon/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangTidyZirconModule
6+
add_clang_library(clangTidyZirconModule STATIC
77
TemporaryObjectsCheck.cpp
88
ZirconTidyModule.cpp
99

clang-tools-extra/clangd/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ endif()
6161
include_directories(BEFORE "${CMAKE_CURRENT_BINARY_DIR}/../clang-tidy")
6262
include_directories(BEFORE "${CMAKE_CURRENT_SOURCE_DIR}/../include-cleaner/include")
6363

64-
add_clang_library(clangDaemon
64+
add_clang_library(clangDaemon STATIC
6565
AST.cpp
6666
ASTSignals.cpp
6767
ClangdLSPServer.cpp

clang-tools-extra/clangd/index/remote/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ if (CLANGD_ENABLE_REMOTE)
1919
# target-local?
2020
add_definitions(-DGOOGLE_PROTOBUF_NO_RTTI=1)
2121

22-
add_clang_library(clangdRemoteIndex
22+
add_clang_library(clangdRemoteIndex STATIC
2323
Client.cpp
2424

2525
LINK_LIBS

clang-tools-extra/clangd/index/remote/marshalling/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
add_clang_library(clangdRemoteMarshalling
1+
add_clang_library(clangdRemoteMarshalling STATIC
22
Marshalling.cpp
33

44
LINK_LIBS

clang-tools-extra/clangd/index/remote/unimplemented/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../../../)
22
# When compiled without Remote Index support, the real implementation index
33
# client is not present. Users will get a notification about this when trying
44
# to connect to remote index server instance.
5-
add_clang_library(clangdRemoteIndex
5+
add_clang_library(clangdRemoteIndex STATIC
66
UnimplementedClient.cpp
77

88
LINK_LIBS

clang-tools-extra/clangd/support/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ if(NOT HAVE_CXX_ATOMICS_WITHOUT_LIB OR NOT HAVE_CXX_ATOMICS64_WITHOUT_LIB)
1515
list(APPEND CLANGD_ATOMIC_LIB "atomic")
1616
endif()
1717

18-
add_clang_library(clangdSupport
18+
add_clang_library(clangdSupport STATIC
1919
Bracket.cpp
2020
Cancellation.cpp
2121
Context.cpp

clang-tools-extra/clangd/tool/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Needed by LLVM's CMake checks because this file defines multiple targets.
22
set(LLVM_OPTIONAL_SOURCES ClangdToolMain.cpp)
33

4-
add_clang_library(clangdMain
4+
add_clang_library(clangdMain STATIC
55
ClangdMain.cpp
66
Check.cpp
77
)

clang-tools-extra/clangd/xpc/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ set(LLVM_LINK_COMPONENTS
1414
# Needed by LLVM's CMake checks because this file defines multiple targets.
1515
set(LLVM_OPTIONAL_SOURCES Conversion.cpp XPCTransport.cpp)
1616

17-
add_clang_library(clangdXpcJsonConversions
17+
add_clang_library(clangdXpcJsonConversions STATIC
1818
Conversion.cpp
1919
LINK_LIBS clangDaemon clangdSupport
2020
)
2121

22-
add_clang_library(clangdXpcTransport
22+
add_clang_library(clangdXpcTransport STATIC
2323
XPCTransport.cpp
2424
LINK_LIBS clangDaemon clangdSupport clangdXpcJsonConversions
2525
DEPENDS ClangDriverOptions

0 commit comments

Comments
 (0)