[lldb][test][x86_64][win] TestBreakpointConditions set condition on breakpoint instead of location

On windows x86_64 this test stops on the set breakpoint
when val == 1 when the breakpoint condition is set on the
SBBreakpointLocation rather than the SBBreakpoint directly.
Setting the condition on the breakpoint itself, seems to fix the issue.

This PR also splits the test assertion that verifies we're
on the correct line and have the correct value of val to make the
error message more clear. At present it just shows Assertion error: True != False

Author: kendal

lldb/test/API/functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py

@@ -21,6 +21,17 @@ def test_breakpoint_condition_inline_and_run_command(self):
 
     @add_test_categories(["pyapi"])
     def test_breakpoint_condition_and_python_api(self):
+        """Use Python APIs to set breakpoint conditions."""
+        self.build()
+        self.breakpoint_conditions_python(set_breakpoint_on_location=False)
+
+    @add_test_categories(["pyapi"])
+    @expectedFailureAll(
+        oslist=["windows"],
+        archs=["x86_64"],
+        bugnumber="https://github.com/llvm/llvm-project/issues/100486",
+    )
+    def test_breakpoint_condition_on_location_and_python_api(self):
         """Use Python APIs to set breakpoint conditions."""
         self.build()
         self.breakpoint_conditions_python()
@@ -124,7 +135,7 @@ def breakpoint_conditions(self, inline=False):
 
         self.runCmd("process kill")
 
-    def breakpoint_conditions_python(self):
+    def breakpoint_conditions_python(self, set_breakpoint_on_location=True):
         """Use Python APIs to set breakpoint conditions."""
         target = self.createTestTarget()
 
@@ -158,10 +169,14 @@ def breakpoint_conditions_python(self):
         # Get the breakpoint location from breakpoint after we verified that,
         # indeed, it has one location.
         location = breakpoint.GetLocationAtIndex(0)
-        self.assertTrue(location and location.IsEnabled(), VALID_BREAKPOINT_LOCATION)
 
-        # Set the condition on the breakpoint location.
-        location.SetCondition("val == 3")
+        # Set the condition.
+        if set_breakpoint_on_location:
+            location.SetCondition("val == 3")
+        else:
+            breakpoint.SetCondition("val == 3")
+
+        self.assertTrue(location and location.IsEnabled(), VALID_BREAKPOINT_LOCATION)
         self.expect(location.GetCondition(), exe=False, startstr="val == 3")
 
         # Now launch the process, and do not stop at entry point.