Addressing reviewers (2)

Author: paschalis-mpeis

llvm/lib/Analysis/LoopAccessAnalysis.cpp

@@ -2495,9 +2495,9 @@ void LoopAccessInfo::analyzeLoop(AAResults *AA, LoopInfo *LI,
         // We can safety handle math functions that have vectorized
         // counterparts and have the memory write-only attribute set.
         if (isMathLibCallMemWriteOnly(TLI, I)) {
-          LLVM_DEBUG(dbgs()
-                     << "LAA: allow math function with write-only attribute:"
-                     << I << "\n");
+          LLVM_DEBUG(dbgs() << "LAA: Allow to vectorize math function with "
+                               "write-only attribute:"
+                            << I << "\n");
           continue;
         }
 

llvm/test/Analysis/LoopAccessAnalysis/attr-mem-write-only.ll

@@ -4,9 +4,13 @@
 
 target triple = "aarch64-unknown-linux-gnu"
 
-; TODO: add mappings for frexp/frexpf
+; LoopVectorizer's Legality does not let vectorization to happen because there
+; is no scalar to vector mapping in TLI for frexp/frexpf. As a result, LAA will
+; never encounter such loops.
+; Tests will need to be changed when such mappings are added.
 
 define void @frexp_f64(ptr %in, ptr %out1, ptr %out2, i32 %N) {
+; CHECK-NOT: LAA: Allow to vectorize math function with write-only attribute: %call = tail call double @frexp
 entry:
   %cmp4 = icmp sgt i32 %N, 0
   br i1 %cmp4, label %for.body.preheader, label %for.cond.cleanup
@@ -33,6 +37,7 @@ for.body:
 declare double @frexp(double, ptr) #1
 
 define void @frexp_f32(ptr readonly %in, ptr %out1, ptr %out2, i32 %N) {
+; CHECK-NOT: LAA: Allow to vectorize math function with write-only attribute: %call = tail call float @frexpf
 entry:
   %cmp4 = icmp sgt i32 %N, 0
   br i1 %cmp4, label %for.body.preheader, label %for.cond.cleanup
@@ -59,7 +64,7 @@ for.body:
 declare float @frexpf(float , ptr) #1
 
 define void @modf_f64(ptr %in, ptr %out1, ptr %out2, i32 %N) {
-; CHECK: LAA: allow math function with write-only attribute:  %call = tail call double @modf
+; CHECK: LAA: Allow to vectorize math function with write-only attribute: %call = tail call double @modf
 entry:
   %cmp7 = icmp sgt i32 %N, 0
   br i1 %cmp7, label %for.body.preheader, label %for.cond.cleanup
@@ -87,7 +92,7 @@ for.body:
 declare double @modf(double , ptr ) #1
 
 define void @modf_f32(ptr %in, ptr %out1, ptr %out2, i32 %N) {
-; CHECK: LAA: allow math function with write-only attribute:  %call = tail call float @modff
+; CHECK: LAA: Allow to vectorize math function with write-only attribute: %call = tail call float @modff
 entry:
   %cmp7 = icmp sgt i32 %N, 0
   br i1 %cmp7, label %for.body.preheader, label %for.cond.cleanup

llvm/test/Transforms/LoopVectorize/AArch64/veclib-function-calls-linear-ptrs.ll

@@ -3,7 +3,9 @@
 
 target triple = "aarch64-unknown-linux-gnu"
 
-; TODO: add mappings for frexp/frexpf
+; Vectorization can not happen because there is no scalar to vector mapping in
+; TLI for frexp/frexpf. Tests will need to be changed when such mappings are
+; added.
 
 define void @frexp_f64(ptr %in, ptr %out1, ptr %out2, i32 %N) {
 ; CHECK-LABEL: define void @frexp_f64(