Skip to content

Commit 593b9db

Browse files
author
Manuel Kalettka
committed
[Coverage] Map regions from system headers
In 2155195, the "system-headers-coverage" option has been added but not used in all necessary places.
1 parent 4de971c commit 593b9db

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

clang/lib/CodeGen/CodeGenPGO.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ static llvm::cl::opt<bool>
2828
llvm::cl::desc("Enable value profiling"),
2929
llvm::cl::Hidden, llvm::cl::init(false));
3030

31+
extern llvm::cl::opt<bool> SystemHeadersCoverage;
32+
3133
using namespace clang;
3234
using namespace CodeGen;
3335

@@ -885,7 +887,7 @@ bool CodeGenPGO::skipRegionMappingForDecl(const Decl *D) {
885887
// Don't map the functions in system headers.
886888
const auto &SM = CGM.getContext().getSourceManager();
887889
auto Loc = D->getBody()->getBeginLoc();
888-
return SM.isInSystemHeader(Loc);
890+
return !SystemHeadersCoverage && SM.isInSystemHeader(Loc);
889891
}
890892

891893
void CodeGenPGO::emitCounterRegionMapping(const Decl *D) {

clang/lib/CodeGen/CoverageMappingGen.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ static llvm::cl::opt<bool> EmptyLineCommentCoverage(
3737
"disable it on test)"),
3838
llvm::cl::init(true), llvm::cl::Hidden);
3939

40-
static llvm::cl::opt<bool> SystemHeadersCoverage(
40+
llvm::cl::opt<bool> SystemHeadersCoverage(
4141
"system-headers-coverage",
4242
llvm::cl::desc("Enable collecting coverage from system headers"),
4343
llvm::cl::init(false), llvm::cl::Hidden);

0 commit comments

Comments
 (0)