Skip to content

Commit 9d436c4

Browse files
committed
leave TODO that getSize should return TypeSize in the header file
1 parent 09866e5 commit 9d436c4

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

llvm/include/llvm/CodeGen/MachineMemOperand.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,7 @@ class MachineMemOperand {
235235
LLT getMemoryType() const { return MemoryType; }
236236

237237
/// Return the size in bytes of the memory reference.
238+
// TODO: should return TypeSize
238239
uint64_t getSize() const {
239240
return MemoryType.isValid() ? MemoryType.getSizeInBytes() : ~UINT64_C(0);
240241
}

llvm/lib/CodeGen/MachineOperand.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1243,7 +1243,7 @@ void MachineMemOperand::print(raw_ostream &OS, ModuleSlotTracker &MST,
12431243
uint64_t MinSize = MemoryType.isValid()
12441244
? getType().getSizeInBytes().getKnownMinValue()
12451245
: ~UINT64_C(0);
1246-
// TODO: getSize should return TypeSize
1246+
12471247
if (MinSize > 0 && getAlign() != MinSize)
12481248
OS << ", align " << getAlign().value();
12491249
if (getAlign() != getBaseAlign())

0 commit comments

Comments
 (0)