address pr comments - add int and mismatched args error tests, remove spirv double test

Author: kmpeng

clang/test/CodeGenSPIRV/Builtins/smoothstep.c

@@ -42,3 +42,10 @@ float3 test_smoothstep_float3(float3 Min, float3 Max, float3 X) { return __built
 //
 float4 test_smoothstep_float4(float4 Min, float4 Max, float4 X) { return __builtin_spirv_smoothstep(Min, Max, X); }
 
+// CHECK-LABEL: define spir_func double @test_smoothstep_double(
+// CHECK-SAME: double noundef [[MIN:%.*]], double noundef [[MAX:%.*]], double noundef [[X:%.*]]) local_unnamed_addr #[[ATTR0]] {
+// CHECK-NEXT:  [[ENTRY:.*:]]
+// CHECK-NEXT:    [[SPV_SMOOTHSTEP:%.*]] = tail call double @llvm.spv.smoothstep.f64(double [[MIN]], double [[MAX]], double [[X]])
+// CHECK-NEXT:    ret double [[SPV_SMOOTHSTEP]]
+//
+double test_smoothstep_double(double Min, double Max, double X) { return __builtin_spirv_smoothstep(Min, Max, X); }

clang/test/SemaSPIRV/BuiltIns/smoothstep-errors.c

@@ -1,6 +1,7 @@
 // RUN: %clang_cc1 %s -triple spirv-pc-vulkan-compute -verify
 
 typedef float float2 __attribute__((ext_vector_type(2)));
+typedef float float3 __attribute__((ext_vector_type(3)));
 
 float2 test_no_second_arg(float2 p0) {
   return __builtin_spirv_smoothstep(p0);
@@ -16,3 +17,28 @@ float2 test_too_many_arg(float2 p0) {
   return __builtin_spirv_smoothstep(p0, p0, p0, p0);
   // expected-error@-1 {{too many arguments to function call, expected 3, have 4}}
 }
+
+int test_int_scalar_inputs(int p0) {
+  return __builtin_spirv_smoothstep(p0, p0, p0);
+  //  expected-error@-1 {{passing 'int' to parameter of incompatible type 'float'}}
+}
+
+float test_mismatched_arg(float p0, float2 p1) {
+  return __builtin_spirv_smoothstep(p0, p1, p1);
+  // expected-error@-1 {{all arguments to '__builtin_spirv_smoothstep' must have the same type}}
+}
+
+float test_mismatched_arg2(float p0, float2 p1) {
+  return __builtin_spirv_smoothstep(p0, p0, p1);
+  // expected-error@-1 {{all arguments to '__builtin_spirv_smoothstep' must have the same type}}
+}
+
+float test_mismatched_return(float2 p0) {
+  return __builtin_spirv_smoothstep(p0, p0, p0);
+  // expected-error@-1 {{returning 'float2' (vector of 2 'float' values) from a function with incompatible result type 'float'}}
+}
+
+float3 test_mismatched_return2(float2 p0) {
+  return __builtin_spirv_smoothstep(p0, p0, p0);
+  // expected-error@-1 {{returning 'float2' (vector of 2 'float' values) from a function with incompatible result type 'float3' (vector of 3 'float' values)}}
+}