Address Aarons's feedback

Author: cor3ntin

clang/include/clang/Sema/Overload.h

@@ -1002,6 +1002,8 @@ class Sema;
       /// using either a parenthesized or braced list of arguments.
       CSK_InitByConstructor,
 
+      /// C++ [over.match.call.general]
+      /// Resolve a call through the address of an overload set.
       CSK_AddressOfOverloadSet,
     };
 

clang/lib/Sema/SemaExpr.cpp

@@ -5826,11 +5826,11 @@ static bool isParenthetizedAndQualifiedAddressOfExpr(Expr *Fn) {
   if (!UO || UO->getOpcode() != clang::UO_AddrOf)
     return false;
   if (auto *DRE = dyn_cast<DeclRefExpr>(UO->getSubExpr()->IgnoreParens())) {
+    assert(isa<FunctionDecl>(DRE->getDecl()) && "expected a function");
     return DRE->hasQualifier();
   }
-  if (auto *OVL = dyn_cast<OverloadExpr>(UO->getSubExpr()->IgnoreParens())) {
+  if (auto *OVL = dyn_cast<OverloadExpr>(UO->getSubExpr()->IgnoreParens()))
     return OVL->getQualifier();
-  }
   return false;
 }