Skip to content

Commit d5622de

Browse files
authored
[mlir][sparse] rename map utility (#68611)
Rename util genReaderBuffers -> genMapBuffers since it is no longer specific to the reader, but all MapRef data in general.
1 parent 07d2e90 commit d5622de

File tree

4 files changed

+18
-18
lines changed

4 files changed

+18
-18
lines changed

mlir/lib/Dialect/SparseTensor/Transforms/CodegenUtils.cpp

+6-6
Original file line numberDiff line numberDiff line change
@@ -774,12 +774,12 @@ Value sparse_tensor::genReader(OpBuilder &builder, Location loc,
774774
return reader;
775775
}
776776

777-
Value sparse_tensor::genReaderBuffers(OpBuilder &builder, Location loc,
778-
SparseTensorType stt,
779-
ArrayRef<Value> dimShapesValues,
780-
Value dimSizesBuffer,
781-
/*out*/ Value &dim2lvlBuffer,
782-
/*out*/ Value &lvl2dimBuffer) {
777+
Value sparse_tensor::genMapBuffers(OpBuilder &builder, Location loc,
778+
SparseTensorType stt,
779+
ArrayRef<Value> dimShapesValues,
780+
Value dimSizesBuffer,
781+
/*out*/ Value &dim2lvlBuffer,
782+
/*out*/ Value &lvl2dimBuffer) {
783783
const Dimension dimRank = stt.getDimRank();
784784
const Level lvlRank = stt.getLvlRank();
785785
// For an identity mapping, the dim2lvl and lvl2dim mappings are

mlir/lib/Dialect/SparseTensor/Transforms/CodegenUtils.h

+5-5
Original file line numberDiff line numberDiff line change
@@ -353,11 +353,11 @@ Value genReader(OpBuilder &builder, Location loc, SparseTensorType stt,
353353
/*out*/ SmallVectorImpl<Value> &dimShapeValues,
354354
/*out*/ Value &dimSizesBuffer);
355355

356-
/// Generates code to set up the buffer parameters for a reader.
357-
Value genReaderBuffers(OpBuilder &builder, Location loc, SparseTensorType stt,
358-
ArrayRef<Value> dimShapeValues, Value dimSizesBuffer,
359-
/*out*/ Value &dim2lvlBuffer,
360-
/*out*/ Value &lvl2dimBuffer);
356+
/// Generates code to set up the buffer parameters for a map.
357+
Value genMapBuffers(OpBuilder &builder, Location loc, SparseTensorType stt,
358+
ArrayRef<Value> dimShapeValues, Value dimSizesBuffer,
359+
/*out*/ Value &dim2lvlBuffer,
360+
/*out*/ Value &lvl2dimBuffer);
361361

362362
//===----------------------------------------------------------------------===//
363363
// Inlined constant generators.

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorCodegen.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -1478,8 +1478,8 @@ struct SparseNewConverter : public OpConversionPattern<NewOp> {
14781478
// Now construct the dim2lvl and lvl2dim buffers.
14791479
Value dim2lvlBuffer;
14801480
Value lvl2dimBuffer;
1481-
genReaderBuffers(rewriter, loc, dstTp, dimShapesValues, dimSizesBuffer,
1482-
dim2lvlBuffer, lvl2dimBuffer);
1481+
genMapBuffers(rewriter, loc, dstTp, dimShapesValues, dimSizesBuffer,
1482+
dim2lvlBuffer, lvl2dimBuffer);
14831483

14841484
// Read the COO tensor data.
14851485
Value xs = desc.getAOSMemRef();

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorConversion.cpp

+5-5
Original file line numberDiff line numberDiff line change
@@ -205,9 +205,9 @@ class NewCallParams final {
205205
params[kParamLvlTypes] = genLvlTypesBuffer(builder, loc, stt);
206206
// Construct dimSizes, lvlSizes, dim2lvl, and lvl2dim buffers.
207207
params[kParamDimSizes] = allocaBuffer(builder, loc, dimSizesValues);
208-
params[kParamLvlSizes] = genReaderBuffers(
209-
builder, loc, stt, dimSizesValues, params[kParamDimSizes],
210-
params[kParamDim2Lvl], params[kParamLvl2Dim]);
208+
params[kParamLvlSizes] =
209+
genMapBuffers(builder, loc, stt, dimSizesValues, params[kParamDimSizes],
210+
params[kParamDim2Lvl], params[kParamLvl2Dim]);
211211
// Secondary and primary types encoding.
212212
setTemplateTypes(stt);
213213
// Finally, make note that initialization is complete.
@@ -446,8 +446,8 @@ class SparseTensorNewConverter : public OpConversionPattern<NewOp> {
446446
Value dim2lvlBuffer;
447447
Value lvl2dimBuffer;
448448
Value lvlSizesBuffer =
449-
genReaderBuffers(rewriter, loc, stt, dimShapesValues, dimSizesBuffer,
450-
dim2lvlBuffer, lvl2dimBuffer);
449+
genMapBuffers(rewriter, loc, stt, dimShapesValues, dimSizesBuffer,
450+
dim2lvlBuffer, lvl2dimBuffer);
451451
// Use the `reader` to parse the file.
452452
Type opaqueTp = getOpaquePointerType(rewriter);
453453
Type eltTp = stt.getElementType();

0 commit comments

Comments
 (0)