Skip to content

[DirectX] Extend existing Module pass to collect shader flags per-function #111867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #57
bharadwajy opened this issue Oct 10, 2024 · 0 comments · Fixed by #112967
Closed
Tracked by #57

[DirectX] Extend existing Module pass to collect shader flags per-function #111867

bharadwajy opened this issue Oct 10, 2024 · 0 comments · Fixed by #112967
Assignees

Comments

@bharadwajy
Copy link
Contributor

bharadwajy commented Oct 10, 2024

Current implementation of ComputedShaderFlags::computeFlags(Module &M) collects a single shader flags mask for the entire module.

Change the implementation to collect shader module masks per-function of the module.

AC:

  1. Implement a map of function to the shader flags mask representing various properties
  2. Update existing tests to verify the change.

This change is not expected to include analyzing for any new shader flags other than ensuring the existing DX11_1_DoubleExtensions (viz., m_bDoubleExtensions in dxc) continues to be set correctly.

@bharadwajy bharadwajy changed the title [DirectX][DXIL] Extend existing Module pass to collect shader flags per-function [DirectX] Extend existing Module pass to collect shader flags per-function Oct 10, 2024
@bharadwajy bharadwajy moved this to Planning in HLSL Support Oct 14, 2024
@bharadwajy bharadwajy self-assigned this Oct 15, 2024
@davidcook-msft davidcook-msft moved this from Planning to Ready in HLSL Support Oct 15, 2024
@bharadwajy bharadwajy moved this from Ready to Needs Review in HLSL Support Oct 22, 2024
@bharadwajy bharadwajy moved this from Needs Review to Active in HLSL Support Oct 24, 2024
@bharadwajy bharadwajy moved this from Active to Needs Review in HLSL Support Oct 28, 2024
@bharadwajy bharadwajy moved this from Needs Review to Active in HLSL Support Nov 19, 2024
@github-project-automation github-project-automation bot moved this from Active to Closed in HLSL Support Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants