Skip to content

[DirectX] Implement Shader Flags Analysis for DX11_1_DoubleExtensions #114554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #113505
bharadwajy opened this issue Nov 1, 2024 · 2 comments
Closed
Tracked by #113505

[DirectX] Implement Shader Flags Analysis for DX11_1_DoubleExtensions #114554

bharadwajy opened this issue Nov 1, 2024 · 2 comments
Labels
backend:DirectX duplicate Resolved as duplicate

Comments

@bharadwajy
Copy link
Contributor

bharadwajy commented Nov 1, 2024 •
edited
Loading

Currently all instructions except the following case are inspected to determine if DX11_1_DoubleExtensions flag is to be set.

Set function-level flag DX11_1_DoubleExtensions flag if the function calls DXIL::Opcode::Fma.

This flag is named m_bEnableDoubleExtensions in dxc sources.

AC:

Add tests to verify the flag is set.
@bharadwajy bharadwajy changed the title [DirectX] Implement Shader Flags Analysis for Doubles [DirectX] Implement Shader Flags Analysis for DX11_1_DoubleExtensions Nov 1, 2024
@bharadwajy bharadwajy mentioned this issue Nov 1, 2024
Closed
5 tasks
@bharadwajy bharadwajy moved this to Planning in HLSL Support Nov 5, 2024
@davidcook-msft davidcook-msft moved this from Planning to Ready in HLSL Support Nov 5, 2024
@bharadwajy bharadwajy mentioned this issue Nov 22, 2024
Merged
@bharadwajy bharadwajy self-assigned this Jan 13, 2025
@bharadwajy bharadwajy moved this from Ready to Active in HLSL Support Jan 13, 2025
@Icohedron Icohedron self-assigned this Apr 11, 2025
@Icohedron
Copy link
Contributor

This is blocked on #99117

@Icohedron Icohedron moved this from Active to Ready in HLSL Support Apr 15, 2025
@Icohedron Icohedron removed their assignment Apr 16, 2025
@Icohedron
Copy link
Contributor

Merging this issue with the fma implementation #99117

@github-project-automation github-project-automation bot moved this from Ready to Closed in HLSL Support Apr 16, 2025
@EugeneZelenko EugeneZelenko added the duplicate Resolved as duplicate label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend:DirectX duplicate Resolved as duplicate
Projects
HLSL Support
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Icohedron @EugeneZelenko @bharadwajy