Support pseudodestructors on void in microsoft mode

[nico]

Bugzilla Link	11791
Resolution	FIXED
Resolved on	Aug 27, 2014 08:48
Version	unspecified
OS	Windows NT
Blocks	llvm/llvm-bugzilla-archive#13707
CC	@asl,@DougGregor,@rnk

Extended Description

cl.exe accepts this program:

template
void _DebugHeapDelete(_Ty *_Ptr)
{
if (_Ptr != 0)
{
_Ptr->~_Ty();
}
}

void f() {
int* a = 0;
_DebugHeapDelete((void*)a);
}

clang rejects it (it's accepted without the void* cast). This appears in the xdebug header of msvc's library.

(Workaround: Don't do debug builds.)

[nico]

r148682

[rnk]

There was a small problem with the fix: we returned ExprError() after diagnosing with a warning, instead of producing a valid AST.

Small fix in r207771.

[tritao]

mentioned in issue llvm/llvm-bugzilla-archive#13707