Skip to content

Request Commit Access For Icohedron #123838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Icohedron opened this issue Jan 21, 2025 · 6 comments
Closed

Request Commit Access For Icohedron #123838

Icohedron opened this issue Jan 21, 2025 · 6 comments

Comments

@Icohedron
Copy link
Contributor

Icohedron commented Jan 21, 2025

Why Are you requesting commit access ?

I am part of the team at Microsoft currently working on implementing HLSL support in Clang/LLVM for the DXIL and SPIR-V backends.
I have so far created 4 PRs that have been reviewed and merged with the help of my colleagues.

More contributions will be coming as I continue to work on the team.
Therefore, I would like to request commit access to streamline the process by which my future contributions will be made.

@llvmbot
Copy link
Member

llvmbot commented Jan 21, 2025

@llvm/issue-subscribers-infra-commit-access-request

Author: Deric Cheung (Icohedron)

### Why Are you requesting commit access ?

I am part of the team at Microsoft currently working on implementing HLSL support in Clang/LLVM for the DXIL and SPIR-V backends.
I have so far created 2 PRs that have been reviewed and merged with the help of my colleagues.

  • #122202
  • #122992

More contributions will be coming as I continue to work on the team.
Therefore, I would like to request commit access to streamline the process by which my future contributions will be made.

@tstellar
Copy link
Collaborator

Activity Summary:

@bogner
Copy link
Contributor

bogner commented Feb 19, 2025

LGTM. Deric has recently joined our team and has been making good contributions to HLSL and DirectX

@s-perron
Copy link
Contributor

LGTM

@bogner
Copy link
Contributor

bogner commented Feb 24, 2025

@tstellar Can we get Deric commit access please? I believe we've satisfied all of the requirements of the new policy.

@tstellar
Copy link
Collaborator

@Icohedron, you have been granted commit access. Please review the project's code review policy before submitting a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants