Skip to content

DirectX codegen tests failing when ran under hwasan #128598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Icohedron opened this issue Feb 24, 2025 · 3 comments
Closed

DirectX codegen tests failing when ran under hwasan #128598

Icohedron opened this issue Feb 24, 2025 · 3 comments
Labels
backend:DirectX question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead!

Comments

@Icohedron
Copy link
Contributor

Icohedron commented Feb 24, 2025

After the merging of a PR (#128556) fix to DirectX build breaks, 28 DirectX tests are failing when ran under my hwasan build of this PR's branch.
See this log: https://gist.github.com/Icohedron/54739cbd0ab952d666bf376e76c9bb85

Similar to issue #124045, it appears to be related to the use of -o /dev/null with llc

/workspace/llvm-project/build/bin/llc /workspace/llvm-project/llvm/test/CodeGen/DirectX/BufferStore-errors.ll -o /dev/null 2>&1
error: <unknown>:0:0: in function storetoomany void (<5 x float>, i32): typedBufferStore data must be a vector of 4 elements

error: <unknown>:0:0: in function storetoofew void (<3 x i32>, i32): typedBufferStore data must be a vector of 4 elements

pure virtual method called
terminate called without an active exception
Aborted

Replacing -o /dev/null with -o - makes the tests pass.

This is odd because @vitalybuka supposedly patched a similar issue w.r.t. a SPIRV codegen error test ( #125599 (comment) )

@vitalybuka
Copy link
Collaborator

pure virtual method called?

I fixed only memory leaks, which where cause of the previous revert

@vitalybuka
Copy link
Collaborator

And our HWASAN bot does not fail after #128556 https://lab.llvm.org/buildbot/#/builders/55/builds/7503

@Icohedron
Copy link
Contributor Author

That's odd. I'll close this issue then. My local hwasan setup may just be outdated.

@EugeneZelenko EugeneZelenko added the question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead! label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:DirectX question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead!
Projects
Status: Closed
Development

No branches or pull requests

4 participants