Skip to content

[Flang][Windows] Backport fixes for CMake + Flang on Windows #70458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
omjavaid opened this issue Oct 27, 2023 · 6 comments · Fixed by llvm/llvm-project-release-prs#752
Closed

[Flang][Windows] Backport fixes for CMake + Flang on Windows #70458

omjavaid opened this issue Oct 27, 2023 · 6 comments · Fixed by llvm/llvm-project-release-prs#752
Labels
mlir:llvm release:backport release:merged
Milestone
LLVM 17.0.X Release

Comments

@omjavaid
Copy link
Contributor

CMake support for flang MSVC was broken and has been merged recently [1].
CMake 3.28 will have all the latest fixes required for Flang + MSVC combination.

Compiling Fortran OpenBLAS project with llvm-17 and latest CMake still caused issues which were fixed by #66516 which depends on #66270

This issue aims to backport both these PRs to 17.x to have Flang successfully build projects like OpenBLAS which used along MSVC.
@omjavaid omjavaid added this to the LLVM 17.0.X Release milestone Oct 27, 2023
@github-actions github-actions bot added the flang Flang issues not falling into any other category label Oct 27, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Oct 27, 2023
@omjavaid
Copy link
Contributor Author

/cherry-pick a685715

@EugeneZelenko EugeneZelenko added mlir:llvm release:backport and removed flang Flang issues not falling into any other category labels Oct 27, 2023
@llvmbot
Copy link
Member

llvmbot commented Oct 27, 2023

@llvm/issue-subscribers-mlir-llvm

Author: Omair Javaid (omjavaid)

CMake support for flang MSVC was broken and has been merged recently [1]. CMake 3.28 will have all the latest fixes required for Flang + MSVC combination.

Compiling Fortran OpenBLAS project with llvm-17 and latest CMake still caused issues which were fixed by #66516 which depends on #66270

This issue aims to backport both these PRs to 17.x to have Flang successfully build projects like OpenBLAS which used along MSVC.

@llvmbot
Copy link
Member

llvmbot commented Oct 27, 2023

/branch llvm/llvm-project-release-prs/issue70458

@omjavaid
Copy link
Contributor Author

/cherry-pick a685715 5f476b8

@llvmbot llvmbot mentioned this issue Oct 27, 2023
Merged
@llvmbot
Copy link
Member

llvmbot commented Oct 27, 2023

/pull-request llvm/llvm-project-release-prs#752

@llvmbot
Copy link
Member

llvmbot commented Oct 27, 2023

/branch llvm/llvm-project-release-prs/issue70458

@tru tru moved this from Needs Triage to Needs Review in LLVM Release Status Oct 30, 2023
@tru tru moved this from Needs Review to Done in LLVM Release Status Oct 31, 2023
@h-vetinari h-vetinari mentioned this issue Mar 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mlir:llvm release:backport release:merged
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 17.0.X Release
Development

Successfully merging a pull request may close this issue.

PR for llvm/llvm-project#70458 llvm/llvm-project-release-prs
3 participants
@EugeneZelenko @omjavaid @llvmbot