Skip to content

LLVM 18.1.5 Release Assets missing some code! #91121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DigOrDog opened this issue May 5, 2024 · 3 comments
Closed

LLVM 18.1.5 Release Assets missing some code! #91121

DigOrDog opened this issue May 5, 2024 · 3 comments
Assignees

Comments

@DigOrDog
Copy link

DigOrDog commented May 5, 2024

I have downloaded the source code for LLVM version 18.1.5 from a source link. However, after decompressing the downloaded source code, I discovered that the changeFCMPPredToAArch64CC method in the AArch64GlobalISelUtils.cpp file, located in the ./llvm/lib/Target/AArch64/GISel/ directory, does not include handling for FCMP_TRUE and FCMP_FALSE. This omission is related to a fix or feature discussed in the issue on the LLVM project's GitHub repository. Can you explain what this situation entails?

@llvmbot
Copy link
Member

llvmbot commented May 5, 2024

@llvm/issue-subscribers-backend-aarch64

Author: None (DigOrDog)

I have downloaded the source code for LLVM version 18.1.5 from [a source link](https://github.com/llvm/llvm-project/archive/refs/tags/llvmorg-18.1.5.tar.gz). However, after decompressing the downloaded source code, I discovered that the changeFCMPPredToAArch64CC method in the AArch64GlobalISelUtils.cpp file, located in the ./llvm/lib/Target/AArch64/GISel/ directory, does not include handling for FCMP_TRUE and FCMP_FALSE. This omission is related to a fix or feature discussed in the [issue](https://github.com//issues/86917) on the LLVM project's GitHub repository. Can you explain what this situation entails?

@marcauberer
Copy link
Member

The fix was not downported to the release/18.x branch yet.
I just triggered the downport. Sorry for the inconvenience.

@marcauberer marcauberer self-assigned this May 5, 2024
@marcauberer marcauberer added this to the LLVM 18.X Release milestone May 5, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status May 5, 2024
@marcauberer marcauberer removed this from the LLVM 18.X Release milestone May 5, 2024
@marcauberer
Copy link
Member

The cherry-pick is now merged to the release/18.x branch, so it will be included in the 18.1.6 release. I am closing this issue, if your problem persists, feel free to reopen it.

@github-project-automation github-project-automation bot moved this from Needs Triage to Done in LLVM Release Status May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants