Skip to content

Implement the isfinite HLSL Function #99131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
9 tasks
Tracked by #99235
farzonl opened this issue Jul 16, 2024 · 0 comments
Open
9 tasks
Tracked by #99235

Implement the isfinite HLSL Function #99131

farzonl opened this issue Jul 16, 2024 · 0 comments
Labels
backend:DirectX bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues.

Comments

@farzonl
Copy link
Member

farzonl commented Jul 16, 2024

  • Implement isfinite clang builtin,
  • Link isfinite clang builtin with hlsl_intrinsics.h
  • Add sema checks for isfinite to CheckHLSLBuiltinFunctionCall in SemaChecking.cpp
  • Add codegen for isfinite to EmitHLSLBuiltinExpr in CGBuiltin.cpp
  • Add codegen tests to clang/test/CodeGenHLSL/builtins/isfinite.hlsl
  • Add sema tests to clang/test/SemaHLSL/BuiltIns/isfinite-errors.hlsl
  • Create the int_dx_isfinite intrinsic in IntrinsicsDirectX.td
  • Create the DXILOpMapping of int_dx_isfinite to 10 in DXIL.td
  • Create the isfinite.ll and isfinite_errors.ll tests in llvm/test/CodeGen/DirectX/

DirectX

DXIL Opcode DXIL OpName Shader Model Shader Stages
10 IsFinite 6.0 ()

SPIR-V

There were no SPIR-V opcodes found for isfinite.

Test Case(s)

Example 1

//dxc isfinite_test.hlsl -T lib_6_8 -enable-16bit-types -O0

export bool4 fn(float4 p1) {
    return isfinite(p1);
}

HLSL:

Determines if the specified floating-point value is finite.

ret isfinite(x)

Parameters

Item Description
x
[in] The specified value.

Return Value

Returns a value of the same size as the input, with a value set to True if the x parameter is finite; otherwise False.

Type Description

Name Template Type Component Type Size
x scalar, vector, or matrix float any
ret scalar, vector, or matrix bool as input

Minimum Shader Model

This function is supported in the following shader models.

Shader Model Supported
Shader Model 2 (DirectX HLSL) and higher shader models yes
Shader Model 1 (DirectX HLSL) yes (vs_1_1 only)

Requirements

Requirement Value
Header
Corecrt_math.h

See also

Intrinsic Functions (DirectX HLSL)

@farzonl farzonl added backend:DirectX bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues. labels Jul 16, 2024
@damyanp damyanp moved this to Ready in HLSL Support Oct 30, 2024
@damyanp damyanp moved this from Ready to Planning in HLSL Support Oct 30, 2024
@pow2clk pow2clk moved this from Planning to Designing in HLSL Support Nov 19, 2024
@damyanp damyanp removed the status in HLSL Support Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:DirectX bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues.
Projects
Status: No status
Development

No branches or pull requests

1 participant