From 22c681018f777c1e1297e2654eda3ccb90993890 Mon Sep 17 00:00:00 2001 From: kmpeng Date: Fri, 18 Apr 2025 11:26:44 -0700 Subject: [PATCH 1/2] xfail smoothstep.ll and SV_GroupIndex.ll tests --- llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll | 3 +++ llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll | 3 +++ 2 files changed, 6 insertions(+) diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll index 83caa62150cda..f5be558929b52 100644 --- a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll +++ b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll @@ -1,6 +1,9 @@ ; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-vulkan-unknown %s -o - | FileCheck %s ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-vulkan-unknown %s -o - -filetype=obj | spirv-val --target-env vulkan1.3 %} +; TODO: This test currently fails when --target-env vulkan1.3 is specified. +; XFAIL: * + ; CHECK-DAG: %[[#int:]] = OpTypeInt 32 0 ; CHECK-DAG: %[[#ptr_Input_int:]] = OpTypePointer Input %[[#int]] ; CHECK-DAG: %[[#LocalInvocationIndex:]] = OpVariable %[[#ptr_Input_int]] Input diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll index e0e04dd0faf58..64f3287f43416 100644 --- a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll +++ b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll @@ -1,6 +1,9 @@ ; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val --target-env vulkan1.3 %} +; TODO: This test currently fails when --target-env vulkan1.3 is specified. +; XFAIL: * + ; Make sure SPIRV operation function calls for smoothstep are lowered correctly. ; CHECK-DAG: %[[#op_ext_glsl:]] = OpExtInstImport "GLSL.std.450" From 0b227f93e8b798134a5f78e89c2969bccfaaa99a Mon Sep 17 00:00:00 2001 From: kmpeng Date: Fri, 18 Apr 2025 12:42:05 -0700 Subject: [PATCH 2/2] xfail only when spirv-tools is enabled, add issue number --- llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll | 4 ++-- llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll index f5be558929b52..1b89485654727 100644 --- a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll +++ b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll @@ -1,8 +1,8 @@ ; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-vulkan-unknown %s -o - | FileCheck %s ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-vulkan-unknown %s -o - -filetype=obj | spirv-val --target-env vulkan1.3 %} -; TODO: This test currently fails when --target-env vulkan1.3 is specified. -; XFAIL: * +; TODO(#136344): This test currently fails when --target-env vulkan1.3 is specified. +; XFAIL: spirv-tools ; CHECK-DAG: %[[#int:]] = OpTypeInt 32 0 ; CHECK-DAG: %[[#ptr_Input_int:]] = OpTypePointer Input %[[#int]] diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll index 64f3287f43416..789b0cb15c9e2 100644 --- a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll +++ b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll @@ -1,8 +1,8 @@ ; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val --target-env vulkan1.3 %} -; TODO: This test currently fails when --target-env vulkan1.3 is specified. -; XFAIL: * +; TODO(#136344): This test currently fails when --target-env vulkan1.3 is specified. +; XFAIL: spirv-tools ; Make sure SPIRV operation function calls for smoothstep are lowered correctly.