diff --git a/libc/src/__support/float_to_string.h b/libc/src/__support/float_to_string.h index d3fcec7a652fa..eb06cd9c08af2 100644 --- a/libc/src/__support/float_to_string.h +++ b/libc/src/__support/float_to_string.h @@ -708,7 +708,7 @@ FloatToString::get_negative_block(int block_index) { const int32_t SHIFT_CONST = TABLE_SHIFT_CONST; // if the requested block is zero - if (block_index <= MIN_BLOCK_2[idx]) { + if (block_index < MIN_BLOCK_2[idx]) { return 0; } const uint32_t p = POW10_OFFSET_2[idx] + block_index - MIN_BLOCK_2[idx]; diff --git a/libc/test/src/stdio/sprintf_test.cpp b/libc/test/src/stdio/sprintf_test.cpp index 8b9c919bed203..b7e8b75485881 100644 --- a/libc/test/src/stdio/sprintf_test.cpp +++ b/libc/test/src/stdio/sprintf_test.cpp @@ -2433,6 +2433,9 @@ TEST_F(LlvmLibcSPrintfTest, FloatAutoConv) { written = LIBC_NAMESPACE::sprintf(buff, "%g", 9999999000000.00); ASSERT_STREQ_LEN(written, buff, "1e+13"); + written = LIBC_NAMESPACE::sprintf(buff, "%g", 0xa.aaaaaaaaaaaaaabp-7); + ASSERT_STREQ_LEN(written, buff, "0.0833333"); + // Simple Subnormal Tests. written = LIBC_NAMESPACE::sprintf(buff, "%g", 0x1.0p-1027); @@ -2457,9 +2460,16 @@ TEST_F(LlvmLibcSPrintfTest, FloatAutoConv) { // Length Modifier Tests. +#if defined(SPECIAL_X86_LONG_DOUBLE) + written = LIBC_NAMESPACE::sprintf(buff, "%Lg", 0xf.fffffffffffffffp+16380L); ASSERT_STREQ_LEN(written, buff, "1.18973e+4932"); + written = LIBC_NAMESPACE::sprintf(buff, "%Lg", 0xa.aaaaaaaaaaaaaabp-7L); + ASSERT_STREQ_LEN(written, buff, "0.0833333"); + +#endif // SPECIAL_X86_LONG_DOUBLE + // TODO: Uncomment the below tests after long double support is added /* written = LIBC_NAMESPACE::sprintf(buff, "%Lf", 1e100L); @@ -2757,6 +2767,15 @@ TEST_F(LlvmLibcSPrintfTest, FloatAutoConv) { written = LIBC_NAMESPACE::sprintf(buff, "%.10g", 0x1.0p-1074); ASSERT_STREQ_LEN(written, buff, "4.940656458e-324"); +#if defined(SPECIAL_X86_LONG_DOUBLE) + + written = LIBC_NAMESPACE::sprintf(buff, "%.60Lg", 0xa.aaaaaaaaaaaaaabp-7L); + ASSERT_STREQ_LEN( + written, buff, + "0.0833333333333333333355920878593448009041821933351457118988037"); + +#endif // SPECIAL_X86_LONG_DOUBLE + // Long double precision tests. // These are currently commented out because they require long double support // that isn't ready yet.