Skip to content

Port this package to Flask #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hxuanhung opened this issue May 16, 2018 · 1 comment
Closed

Port this package to Flask #3

hxuanhung opened this issue May 16, 2018 · 1 comment

Comments

@hxuanhung
Copy link

Hi, I've ported this package successfully to Flask and I want to create a PR for it.

Particularly, I make two changes:

  • from graphene_django.views import GraphQLView to from flask_graphql import GraphQLView
  • and request_type = request.META.get("CONTENT_TYPE") to request_type = request.mimetype

It's not clear for me to make this works for both Flask and Django. Do you have any idea?

@lmcgartland
Copy link
Owner

I think the best thing might be to have to modules exported from this package, a view for Django and one for Flask. They can share the underlying logic. File a pull request just so I can take a look and we can work together on getting it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants