Skip to content

Commit 636fb88

Browse files
committed
chore: remove unusable e2e tests and remove deps to vcluster code base
1 parent 47d57d3 commit 636fb88

File tree

3,910 files changed

+34
-936310
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

3,910 files changed

+34
-936310
lines changed

.github/workflows/e2e.yaml

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -58,20 +58,20 @@ jobs:
5858
run: |
5959
6060
# Install clusterctl
61-
curl -L https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.6.3/clusterctl-linux-amd64 -o clusterctl
61+
curl -L https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.9.3/clusterctl-linux-amd64 -o clusterctl
6262
chmod +x clusterctl
6363
sudo mv clusterctl /usr/local/bin/
6464
6565
#Install Kind
66-
curl -Lo ./kind https://kind.sigs.k8s.io/dl/v0.23.0/kind-linux-amd64
66+
curl -Lo ./kind https://kind.sigs.k8s.io/dl/v0.26.0/kind-linux-amd64
6767
chmod +x ./kind
6868
sudo mv ./kind /usr/local/bin/kind
6969
7070
# Install envsubst
7171
GOBIN="$(pwd)/bin" go install -tags tools github.com/drone/envsubst/v2/cmd/[email protected]
7272
7373
# Install kubectl
74-
curl -LO "https://dl.k8s.io/release/v1.29.2/bin/linux/amd64/kubectl"
74+
curl -LO "https://dl.k8s.io/release/v1.31.4/bin/linux/amd64/kubectl"
7575
chmod +x ./kubectl
7676
sudo mv ./kubectl /usr/local/bin/kubectl
7777
@@ -82,7 +82,7 @@ jobs:
8282
8383
- name: Create and Start Kind Cluster
8484
run: |
85-
kind create cluster --image=kindest/node:v1.28.9@sha256:dca54bc6a6079dd34699d53d7d4ffa2e853e46a20cd12d619a09207e35300bd0
85+
kind create cluster --image=kindest/node:v1.31.4@sha256:2cb39f7295fe7eafee0842b1052a599a4fb0f8bcf3f83d96c7f4864c357c6c30
8686
echo "=== cluster-info ==="
8787
kubectl cluster-info --context kind-kind
8888
@@ -122,9 +122,6 @@ jobs:
122122
run: |
123123
kubectl wait --for=condition=ready vcluster -n vcluster-k3s vcluster-k3s --timeout=100s
124124
125-
- name: Run E2E Tests K3S
126-
run: CLUSTER_NAME=vcluster-k3s NAMESPACE=vcluster-k3s LOCAL_PORT=14550 go test -mod=vendor ./test/e2e -v
127-
128125
- name: Create Vcluster Custom Resource K0S
129126
run: |
130127
export CLUSTER_NAME=vcluster-k0s
@@ -139,9 +136,6 @@ jobs:
139136
run: |
140137
kubectl wait --for=condition=ready vcluster -n vcluster-k0s vcluster-k0s --timeout=100s
141138
142-
- name: Run E2E Tests K0S
143-
run: CLUSTER_NAME=vcluster-k0s NAMESPACE=vcluster-k0s LOCAL_PORT=14551 go test -mod=vendor ./test/e2e -v
144-
145139
- name: Create Vcluster Custom Resource K8S
146140
run: |
147141
export CLUSTER_NAME=vcluster-k8s
@@ -156,5 +150,3 @@ jobs:
156150
run: |
157151
kubectl wait --for=condition=ready vcluster -n vcluster-k8s vcluster-k8s --timeout=100s
158152
159-
- name: Run E2E Tests K8S
160-
run: CLUSTER_NAME=vcluster-k8s NAMESPACE=vcluster-k8s LOCAL_PORT=14552 go test -mod=vendor ./test/e2e -v

controllers/vcluster_controller.go

Lines changed: 29 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,15 @@ import (
2626
"time"
2727

2828
"github.com/go-logr/logr"
29-
"github.com/loft-sh/vcluster/pkg/util"
30-
"github.com/loft-sh/vcluster/pkg/util/kubeconfig"
3129
corev1 "k8s.io/api/core/v1"
3230
kerrors "k8s.io/apimachinery/pkg/api/errors"
3331
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
3432
"k8s.io/apimachinery/pkg/runtime"
33+
"k8s.io/apimachinery/pkg/runtime/schema"
3534
"k8s.io/apimachinery/pkg/types"
3635
utilerrors "k8s.io/apimachinery/pkg/util/errors"
3736
"k8s.io/apimachinery/pkg/util/wait"
37+
"k8s.io/client-go/discovery"
3838
"k8s.io/client-go/kubernetes"
3939
"k8s.io/client-go/rest"
4040
"k8s.io/client-go/tools/clientcmd"
@@ -490,15 +490,15 @@ func DiscoverHostFromService(ctx context.Context, client client.Client, vCluster
490490
}
491491

492492
func GetVClusterKubeConfig(ctx context.Context, clusterClient client.Client, vCluster *v1alpha1.VCluster) (*api.Config, error) {
493-
secretName := kubeconfig.DefaultSecretPrefix + vCluster.Name
493+
secretName := "vc-" + vCluster.Name
494494

495495
secret := &corev1.Secret{}
496496
err := clusterClient.Get(ctx, types.NamespacedName{Namespace: vCluster.Namespace, Name: secretName}, secret)
497497
if err != nil {
498498
return nil, err
499499
}
500500

501-
kcBytes, ok := secret.Data[kubeconfig.KubeconfigSecretKey]
501+
kcBytes, ok := secret.Data["config"]
502502
if !ok {
503503
return nil, fmt.Errorf("couldn't find kube config in vcluster secret")
504504
}
@@ -617,7 +617,7 @@ func EnsureFinalizer(ctx context.Context, client client.Client, obj client.Objec
617617
// SetupWithManager sets up the controller with the Manager.
618618
func (r *VClusterReconciler) SetupWithManager(mgr ctrl.Manager) error {
619619
var err error
620-
r.clusterKindExists, err = util.KindExists(mgr.GetConfig(), clusterv1beta1.GroupVersion.WithKind("Cluster"))
620+
r.clusterKindExists, err = kindExists(mgr.GetConfig(), clusterv1beta1.GroupVersion.WithKind("Cluster"))
621621
if err != nil {
622622
return err
623623
}
@@ -626,3 +626,27 @@ func (r *VClusterReconciler) SetupWithManager(mgr ctrl.Manager) error {
626626
For(&v1alpha1.VCluster{}).
627627
Complete(r)
628628
}
629+
630+
func kindExists(config *rest.Config, groupVersionKind schema.GroupVersionKind) (bool, error) {
631+
discoveryClient, err := discovery.NewDiscoveryClientForConfig(config)
632+
if err != nil {
633+
return false, err
634+
}
635+
636+
resources, err := discoveryClient.ServerResourcesForGroupVersion(groupVersionKind.GroupVersion().String())
637+
if err != nil {
638+
if kerrors.IsNotFound(err) {
639+
return false, nil
640+
}
641+
642+
return false, err
643+
}
644+
645+
for _, r := range resources.APIResources {
646+
if r.Kind == groupVersionKind.Kind {
647+
return true, nil
648+
}
649+
}
650+
651+
return false, nil
652+
}

0 commit comments

Comments
 (0)