chore: switch to GCL modules

Author: johannesfrey

.custom-gcl.yml

@@ -0,0 +1,7 @@
+# This has to be >= v1.57.0 for module plugin system support.
+version: v1.61.0
+plugins:
+  - module: "sigs.k8s.io/logtools"
+    import: "sigs.k8s.io/logtools/logcheck/gclplugin"
+    version: v0.9.0
+

.github/workflows/golangci-lint.yaml

@@ -27,15 +27,11 @@ jobs:
           go-version-file: "go.mod"
           cache: false
 
-      - name: Build logcheck plugin
-        run: go build -o "tools/logcheck.so" -mod=vendor -buildmode=plugin sigs.k8s.io/logtools/logcheck/plugin
-        env:
-          GOWORK: off
+      - name: Install golangci-lint
+        run: go install github.com/golangci/golangci-lint/cmd/[email protected]
 
-      - name: Build golangci-lint
-        run: go build -o "tools/golangci-lint" -mod=vendor ./vendor/github.com/golangci/golangci-lint/cmd/golangci-lint
+      - name: Build custom golangci-lint
+        run: golangci-lint custom
 
       - name: Run golangci-lint
-        run: tools/golangci-lint run --out-format=github-actions ./...
-        env:
-          LOGCHECK_CONFIG: hack/logcheck.conf
+        run: ./custom-gcl run

.gitignore

@@ -35,3 +35,4 @@ devvalues.yaml
 kubeconfig.yaml
 
 /tools
+custom-gcl

.golangci.yaml

@@ -7,6 +7,7 @@ linters:
     - asasalint
     - asciicheck
     - bidichk
+    - copyloopvar
     - decorder
     - dupl
     - durationcheck
@@ -15,7 +16,6 @@ linters:
     - errname
     - errorlint
     - exhaustive
-    - exportloopref
     - ginkgolinter
     - gocheckcompilerdirectives
     - gocritic
@@ -57,9 +57,15 @@ linters:
 linters-settings:
   custom:
     logcheck:
-      path: tools/logcheck.so
+      type: "module"
       description: structured logging checker
       original-url: sigs.k8s.io/logtools/logcheck
+      settings:
+        check:
+          contextual: true
+        config: |
+          structured .*
+          contextual .*
 
   gofmt:
     simplify: true