Remove 30fps cap from playgrounds (flutter#38347)

bdero · loic-sharma · commit bfe7b94dd961 · 2023-01-03T11:05:47.000-08:00
diff --git a/impeller/playground/compute_playground_test.cc b/impeller/playground/compute_playground_test.cc
@@ -53,8 +53,7 @@ std::shared_ptr<RuntimeStage> ComputePlaygroundTest::OpenAssetAsRuntimeStage(
 
 static std::string FormatWindowTitle(const std::string& test_name) {
   std::stringstream stream;
-  stream << "Impeller Playground for '" << test_name
-         << "' (Press ESC or 'q' to quit)";
+  stream << "Impeller Playground for '" << test_name << "' (Press ESC to quit)";
   return stream.str();
 }
 
diff --git a/impeller/playground/playground.cc b/impeller/playground/playground.cc
@@ -145,7 +145,7 @@ static void PlaygroundKeyCallback(GLFWwindow* window,
                                   int scancode,
                                   int action,
                                   int mods) {
-  if ((key == GLFW_KEY_ESCAPE || key == GLFW_KEY_Q) && action == GLFW_RELEASE) {
+  if ((key == GLFW_KEY_ESCAPE) && action == GLFW_RELEASE) {
     if (mods & (GLFW_MOD_CONTROL | GLFW_MOD_SUPER | GLFW_MOD_SHIFT)) {
       gShouldOpenNewPlaygrounds = false;
     }
@@ -227,7 +227,7 @@ bool Playground::OpenPlaygroundHere(
   ::glfwShowWindow(window);
 
   while (true) {
-    ::glfwWaitEventsTimeout(1.0 / 30.0);
+    ::glfwPollEvents();
 
     if (::glfwWindowShouldClose(window)) {
       return true;
diff --git a/impeller/playground/playground_test.cc b/impeller/playground/playground_test.cc
@@ -54,8 +54,7 @@ std::shared_ptr<RuntimeStage> PlaygroundTest::OpenAssetAsRuntimeStage(
 
 static std::string FormatWindowTitle(const std::string& test_name) {
   std::stringstream stream;
-  stream << "Impeller Playground for '" << test_name
-         << "' (Press ESC or 'q' to quit)";
+  stream << "Impeller Playground for '" << test_name << "' (Press ESC to quit)";
   return stream.str();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,7 @@ std::shared_ptr<RuntimeStage> ComputePlaygroundTest::OpenAssetAsRuntimeStage(`
`53`	`53`
`54`	`54`	`static std::string FormatWindowTitle(const std::string& test_name) {`
`55`	`55`	`std::stringstream stream;`
`56`		`- stream << "Impeller Playground for '" << test_name`
`57`		`- << "' (Press ESC or 'q' to quit)";`
	`56`	`+ stream << "Impeller Playground for '" << test_name << "' (Press ESC to quit)";`
`58`	`57`	`return stream.str();`
`59`	`58`	`}`
`60`	`59`
Original file line number	Diff line number	Diff line change
`@@ -54,8 +54,7 @@ std::shared_ptr<RuntimeStage> PlaygroundTest::OpenAssetAsRuntimeStage(`
`54`	`54`
`55`	`55`	`static std::string FormatWindowTitle(const std::string& test_name) {`
`56`	`56`	`std::stringstream stream;`
`57`		`- stream << "Impeller Playground for '" << test_name`
`58`		`- << "' (Press ESC or 'q' to quit)";`
	`57`	`+ stream << "Impeller Playground for '" << test_name << "' (Press ESC to quit)";`
`59`	`58`	`return stream.str();`
`60`	`59`	`}`
`61`	`60`